Skip to content

[New Resources] VPC Route Server #42392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

alexbacchin
Copy link
Contributor

@alexbacchin alexbacchin commented Apr 27, 2025

Description

New Resource(s)

  • aws_vpc_route_server
  • aws_vpc_route_server_association
  • aws_vpc_route_server_endpoint
  • aws_vpc_route_server_propagation
  • aws_vpc_route_server_peer

Relations

Closes #42077

References

https://aws.amazon.com/about-aws/whats-new/2025/04/amazon-vpc-route-server/

Output from Acceptance Testing

%  make testacc TESTS=TestAccVPCRouteServer PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCRouteServer'  -timeout 360m -vet=off
2025/04/27 22:20:20 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCRouteServerAssociation_basic
=== PAUSE TestAccVPCRouteServerAssociation_basic
=== RUN   TestAccVPCRouteServerAssociation_disappears
=== PAUSE TestAccVPCRouteServerAssociation_disappears
=== RUN   TestAccVPCRouteServerEndpoint_basic
=== PAUSE TestAccVPCRouteServerEndpoint_basic
=== RUN   TestAccVPCRouteServerEndpoint_disappears
=== PAUSE TestAccVPCRouteServerEndpoint_disappears
=== RUN   TestAccVPCRouteServerPeer_basic
=== PAUSE TestAccVPCRouteServerPeer_basic
=== RUN   TestAccVPCRouteServerPeer_bgpOptionsBfd
=== PAUSE TestAccVPCRouteServerPeer_bgpOptionsBfd
=== RUN   TestAccVPCRouteServerPeer_disappears
=== PAUSE TestAccVPCRouteServerPeer_disappears
=== RUN   TestAccVPCRouteServerPropagation_basic
=== PAUSE TestAccVPCRouteServerPropagation_basic
=== RUN   TestAccVPCRouteServerPropagation_disappears
=== PAUSE TestAccVPCRouteServerPropagation_disappears
=== RUN   TestAccVPCRouteServer_basic
=== PAUSE TestAccVPCRouteServer_basic
=== RUN   TestAccVPCRouteServer_persistRoutes
=== PAUSE TestAccVPCRouteServer_persistRoutes
=== RUN   TestAccVPCRouteServer_updatePersitRoutesSNSNotification
=== PAUSE TestAccVPCRouteServer_updatePersitRoutesSNSNotification
=== RUN   TestAccVPCRouteServer_disappears
=== PAUSE TestAccVPCRouteServer_disappears
=== CONT  TestAccVPCRouteServerAssociation_basic
=== CONT  TestAccVPCRouteServerPropagation_basic
=== CONT  TestAccVPCRouteServer_disappears
--- PASS: TestAccVPCRouteServer_disappears (30.88s)
=== CONT  TestAccVPCRouteServer_updatePersitRoutesSNSNotification
--- PASS: TestAccVPCRouteServerAssociation_basic (56.97s)
=== CONT  TestAccVPCRouteServer_persistRoutes
--- PASS: TestAccVPCRouteServer_updatePersitRoutesSNSNotification (48.99s)
=== CONT  TestAccVPCRouteServer_basic
--- PASS: TestAccVPCRouteServerPropagation_basic (84.98s)
=== CONT  TestAccVPCRouteServerPropagation_disappears
--- PASS: TestAccVPCRouteServer_basic (26.59s)
=== CONT  TestAccVPCRouteServerPeer_basic
--- PASS: TestAccVPCRouteServer_persistRoutes (50.48s)
=== CONT  TestAccVPCRouteServerPeer_disappears
--- PASS: TestAccVPCRouteServerPropagation_disappears (52.40s)
=== CONT  TestAccVPCRouteServerPeer_bgpOptionsBfd
--- PASS: TestAccVPCRouteServerPeer_disappears (266.63s)
=== CONT  TestAccVPCRouteServerEndpoint_basic
--- PASS: TestAccVPCRouteServerPeer_basic (321.54s)
=== CONT  TestAccVPCRouteServerEndpoint_disappears
--- PASS: TestAccVPCRouteServerPeer_bgpOptionsBfd (301.03s)
=== CONT  TestAccVPCRouteServerAssociation_disappears
--- PASS: TestAccVPCRouteServerAssociation_disappears (51.69s)
--- PASS: TestAccVPCRouteServerEndpoint_basic (121.42s)
--- PASS: TestAccVPCRouteServerEndpoint_disappears (147.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        576.005s

...

Copy link

github-actions bot commented Apr 27, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Apr 27, 2025
@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Apr 27, 2025
Copy link

github-actions bot commented Apr 27, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@alexbacchin alexbacchin marked this pull request as ready for review April 27, 2025 21:57
@alexbacchin alexbacchin marked this pull request as draft April 27, 2025 22:04
@alexbacchin alexbacchin marked this pull request as ready for review April 27, 2025 22:34
@justinretzolk
Copy link
Member

Hey @alexbacchin 👋 Thank you very much for the contribution! In order to help the maintainers with pull request reviews, we ask that pull requests focus on a single data source/resource addition. Would it be possible for you to break this PR out into separate PRs for the individual resources?

@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 28, 2025
@alexbacchin
Copy link
Contributor Author

alexbacchin commented Apr 28, 2025

@justinretzolk It is possible, but not practical. There are dependencies between the resources:

  • aws_vpc_route_server_association depends on aws_vpc_route_server
  • aws_vpc_route_server_endpoint and aws_vpc_route_server_propagation depends on aws_vpc_route_server_association
  • aws_vpc_route_server_peer depends on aws_vpc_route_server_endpoint

Have you had this scenario before? I could mention
In the PR this dependency, however I will have to run the acceptance tests from this combined branch.

The practitioners end goal will be to setup the aws_vpc_route_server_peer the other resources are just to get this done.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 28, 2025
@justinretzolk
Copy link
Member

Thanks for the additional information here @alexbacchin! In that case, let's go ahead and leave the PR as is for now, and I'll let one of the other team members chime in if the need arises.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon VPC Route Server
2 participants