r/aws_elasticache[user|user_group|replication_group]: deprecate non-exact engine values
#42419
+115
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
github-actions
bot
added
documentation
jar-b
force-pushed
the
td-elasticache-engine-uppercase
branch
4 times, most recently
from
2f5232e to
f2f9bf5
Compare
This validator returns a warning diagnostic if the argument value matches a valid value using unicode case-folding, but is not an exact match. It can be used to provide deprecation warnings in cases where non-exact enum value matching is deprecated and planned for removal in future versions.
…xact `engine` values This change deprecates the ability to provide values to the `engine` argument which do not match the casing returned by the AWS API. In `v7.0.0` these resources will require exact value matches during plan time validation. ```console % make testacc PKG=elasticache TESTS=TestAccElastiCacheUser_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUser_' -timeout 360m -vet=off 2025/04/29 15:02:18 Initializing Terraform AWS Provider... --- PASS: TestAccElastiCacheUser_updateEngine (33.57s) --- PASS: TestAccElastiCacheUser_basic (35.65s) --- PASS: TestAccElastiCacheUser_passwordAuthMode (38.07s) --- PASS: TestAccElastiCacheUser_iamAuthMode (40.25s) --- PASS: TestAccElastiCacheUser_tags (97.48s) --- PASS: TestAccElastiCacheUser_update (97.78s) --- PASS: TestAccElastiCacheUser_oobModify (163.52s) --- PASS: TestAccElastiCacheUser_updatePasswordAuthMode (165.17s) --- PASS: TestAccElastiCacheUser_disappears (216.02s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 221.589s ``` ```console % make testacc PKG=elasticache TESTS=TestAccElastiCacheUserGroup_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUserGroup_' -timeout 360m -vet=off 2025/04/29 15:09:40 Initializing Terraform AWS Provider... --- PASS: TestAccElastiCacheUserGroup_tags (149.80s) --- PASS: TestAccElastiCacheUserGroup_disappears (151.02s) --- PASS: TestAccElastiCacheUserGroup_basic (153.59s) --- PASS: TestAccElastiCacheUserGroup_update (335.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 341.074s ``` ```console % make testacc PKG=elasticache TESTS=TestAccElastiCacheReplicationGroup_Redis_basic make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_Redis_basic' -timeout 360m -vet=off 2025/04/29 15:19:53 Initializing Terraform AWS Provider... --- PASS: TestAccElastiCacheReplicationGroup_Redis_basic_v5 (785.84s) --- PASS: TestAccElastiCacheReplicationGroup_Redis_basic (786.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 792.039s ```
jar-b
force-pushed
the
td-elasticache-engine-uppercase
branch
from
f2f9bf5 to
aaf4c9a
Compare
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This was referenced Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change deprecates the ability to provide values to the
engineargument which do not match the casing returned by the AWS API. Inv7.0.0these resources will require exact value matches during plan time validation.Relations
Closes #40813
Relates #41101
References
Output from Acceptance Testing