Skip to content

[WIP] Resource Identity #42487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
170 commits merged into from
Jun 9, 2025
Merged

[WIP] Resource Identity #42487

170 commits merged into from
Jun 9, 2025

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 5, 2025

Description

Implements Resource Identity support, from Terraform v1.12, for several candidate resource types

gdavison added 30 commits April 2, 2025 16:15
@gdavison
Updates dependencies
c182f9c
@gdavison
Adds tfknownvalue.AccountID() check
ee688a2
@gdavison
Adds identity to aws_s3_bucket
76c88d9
@gdavison
Uses acctest.CheckResourceAttrRegionalARNFormat for ARN checks for …
16cc037 
…`aws_batch_job_definition`
@gdavison
Uses acctest.CheckResourceAttrRegionalARNFormat for ARN checks for …
6579549 
…`aws_batch_job_queue`
@gdavison
Adds import test steps for aws_s3_bucket
c9d49b0
@gdavison
Constants
58c283e
@gdavison
Adds identity to aws_route53_record
9c740c5
@gdavison
Adds identity to aws_iam_role
231e4a6
@gdavison
Adds identity to aws_batch_job_definition
3cb89bc
@gdavison
Implements ResourceWithIdentity on Framework wrappedResource
cae6e52
@gdavison
Adds ExpectIdentityRegionalARNFormat state check
20440bb
@gdavison
Adds identity to aws_batch_job_queue
173a107
@gdavison
Adds identity interceptor for SDKv2
0ab828d
@gdavison
Renames service package template
e1c8a22
@gdavison
Adds parameterized identity to SDK resource generation
27513f3
@gdavison
Enables generated Identity for aws_s3_bucket
bfd1310
@gdavison
Adds Required parameter for identity attributes
4385990
@gdavison
Moves Identity schema to resource registration
4095827
@gdavison
Adds ARN identity to SDK resource generation
79cad95
@gdavison
Enables generated Identity for aws_batch_job_definition
f37e977
@gdavison
Linting
ce3031a
@gdavison
Adds global parameterized identity to SDK resource generation
c6989cf
@gdavison
Enables generated Identity for aws_route53_record
d1f3b5b
@gdavison
Enables generated Identity for aws_iam_role
a77956c
@gdavison
Always use generated Identity schema for SDKv2 resource types
8291213
@gdavison
Resource type aws_s3_account_public_access_block is global
8b0022f
@gdavison
Replaces resource.ComposeTestCheckFunc with `resource.ComposeAggreg…
9138e41 
…ateTestCheckFunc`
@gdavison
Checks that id matches account_id
83b99e8
@gdavison
Adds global singleton identity to SDK resource generation
5b6c215
@github-actions github-actions bot added service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/controltower Issues and PRs that pertain to the controltower service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/codecatalyst Issues and PRs that pertain to the codecatalyst service. service/bedrock Issues and PRs that pertain to the bedrock service. service/connectcases Issues and PRs that pertain to the connectcases service. service/appfabric Issues and PRs that pertain to the appfabric service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/datazone Issues and PRs that pertain to the datazone service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/chatbot Issues and PRs that pertain to the chatbot service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/codeconnections Issues and PRs that pertain to the codeconnections service. service/billing Issues and PRs that pertain to the billing service. service/dsql Issues and PRs that pertain to the dsql service. labels May 5, 2025
@ewbankkit ewbankkit added this to the v6.0.0 milestone May 7, 2025
@gdavison gdavison closed this pull request by merging all changes into release/6.0.0-beta in 771ed0a Jun 9, 2025
@gdavison gdavison deleted the f-resource-identity branch June 9, 2025 22:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/account Issues and PRs that pertain to the account service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/billing Issues and PRs that pertain to the billing service. service/budgets Issues and PRs that pertain to the budgets service. service/ce Issues and PRs that pertain to the ce service. service/chatbot Issues and PRs that pertain to the chatbot service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecatalyst Issues and PRs that pertain to the codecatalyst service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codeconnections Issues and PRs that pertain to the codeconnections service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/connectcases Issues and PRs that pertain to the connectcases service. service/controltower Issues and PRs that pertain to the controltower service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/databrew Issues and PRs that pertain to the databrew service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/drs Issues and PRs that pertain to the drs service. service/ds Issues and PRs that pertain to the ds service. service/dsql Issues and PRs that pertain to the dsql service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit