Skip to content

[New Data Source] aws_egress_only_internet_gateway #43319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Intuinewin
Copy link

Description

Implements the aws_egress_only_internet_gateway data source.

It's similar to aws_internet_gateway but the API only supports tags as filters. So the user needs to provide tags or an egress-only gateway identifier.

Relations

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeEgressOnlyInternetGateways.html

Output from Acceptance Testing

% make testacc TESTARGS="-run TestVPCEgressOnlyInternetGatewayDataSource_" PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run TestVPCEgressOnlyInternetGatewayDataSource_ -timeout 360m -vet=off
2025/07/09 13:26:02 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/09 13:26:02 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestVPCEgressOnlyInternetGatewayDataSource_basic
=== PAUSE TestVPCEgressOnlyInternetGatewayDataSource_basic
=== RUN   TestVPCEgressOnlyInternetGatewayDataSource_tags
=== PAUSE TestVPCEgressOnlyInternetGatewayDataSource_tags
=== CONT  TestVPCEgressOnlyInternetGatewayDataSource_basic
=== CONT  TestVPCEgressOnlyInternetGatewayDataSource_tags
--- PASS: TestVPCEgressOnlyInternetGatewayDataSource_tags (24.81s)
--- PASS: TestVPCEgressOnlyInternetGatewayDataSource_basic (24.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.163s

@Intuinewin Intuinewin requested a review from a team as a code owner July 9, 2025 11:47
Copy link

github-actions bot commented Jul 9, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented Jul 9, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. labels Jul 9, 2025
@Intuinewin Intuinewin force-pushed the f-egress-only-internet-gateway branch 2 times, most recently from 9a7beaa to 728cc62 Compare July 9, 2025 11:49
@Intuinewin Intuinewin force-pushed the f-egress-only-internet-gateway branch from 728cc62 to 0bc9065 Compare July 9, 2025 12:09
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants