Skip to content

Commit a7bfdc2

Browse files
katbytesreallymatt
andauthored
Create pull_request_template.md (#1712)
* Create pull_request_template.md * Update .github/pull_request_template.md Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
1 parent 587c145 commit a7bfdc2

File tree

1 file changed

+66
-0
lines changed

1 file changed

+66
-0
lines changed

.github/pull_request_template.md

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
<!-- All Submissions -->
2+
3+
4+
## Community Note
5+
<!-- Please leave the community note as is. -->
6+
* Please vote on this PR by adding a :thumbsup: [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original PR to help the community and maintainers prioritize for review
7+
* Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review
8+
9+
10+
## Description
11+
12+
<!-- Please include a description below with the reason for the PR, what it is doing, what it is trying to accomplish, and anything relevant for a reviewer to know.
13+
14+
If this is a breaking change for users please detail how it cannot be avoided and why it should be made in a minor version of the provider -->
15+
16+
17+
## Changes to existing Resource / Data Source
18+
19+
- [ ] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
20+
- [ ] I have written new tests for my resource or datasource changes & updated any relevant documentation.
21+
- [ ] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
22+
- [ ] (For changes that include a **state migration only**). I have manually tested the migration path between relevant versions of the provider.
23+
24+
25+
## Testing
26+
27+
- [ ] My submission includes Test coverage as described in the [Contribution Guide](../blob/main/contributing/topics/guide-new-resource.md) and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
28+
29+
<!-- Please include testing logs or evidence here or an explanation on why no testing evidence can be provided.
30+
31+
For state migrations please test the changes locally and provide details here, such as the versions involved in testing the migration path. For further details on testing state migration changes please see our guide on [state migrations](https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/guide-state-migrations.md#testing) in the contributor documentation. -->
32+
33+
34+
## Change Log
35+
36+
Below please provide what should go into the changelog (if anything) conforming to the [Changelog Format documented here](../blob/main/contributing/topics/maintainer-changelog.md).
37+
38+
<!-- Replace the changelog example below with your entry. One resource per line. -->
39+
40+
* `azuread_resource` - support for the `thing1` property [GH-00000]
41+
42+
43+
<!-- What type of PR is this? -->
44+
This is a (please select all that apply):
45+
46+
- [ ] Bug Fix
47+
- [ ] New Feature (ie adding a service, resource, or data source)
48+
- [ ] Enhancement
49+
- [ ] Breaking Change
50+
51+
52+
## Related Issue(s)
53+
Fixes #0000
54+
55+
<!-- heimdall_github_prtemplate:grc-pci_dss-2024-01-05 -->
56+
57+
## Rollback Plan
58+
59+
If a change needs to be reverted, we will publish an updated version of the provider.
60+
61+
## Changes to Security Controls
62+
63+
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
64+
65+
> [!NOTE]
66+
> If this PR changes meaningfully during the course of review please update the title and description as required.

0 commit comments

Comments
 (0)