-
Notifications
You must be signed in to change notification settings - Fork 321
fix: escape '/' in azuread_application_identifier_uri to prevent parsing errors #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kenchan0130 - Thanks for this PR. I believe that URL encoding the data could leave to regressions elsewhere. Shell incompatible characters in IDs can be catered for by simply enclosing the ID in "
as below. If you can update the doc with the suggestion and revert the code changes, I can this merged.
Thanks
|
||
```shell | ||
terraform import azuread_application_identifier_uri.example /applications/00000000-0000-0000-0000-000000000000/identifierUris/aHR0cHM6Ly9leGFtcGxlLm5ldC8= | ||
terraform import azuread_application_identifier_uri.example /applications/00000000-0000-0000-0000-000000000000/identifierUris/aHR0cHM6Ly9leGFtcGxlLm5ldC8%3D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL / shell incompatible encoding can be supported by quoting the import line on the cli, such as:
terraform import azuread_application_identifier_uri.example /applications/00000000-0000-0000-0000-000000000000/identifierUris/aHR0cHM6Ly9leGFtcGxlLm5ldC8%3D | |
terraform import azuread_application_identifier_uri.example "/applications/00000000-0000-0000-0000-000000000000/identifierUris/aHR0cHM6Ly9leGFtcGxlLm5ldC8=" |
This differs from my understanding.
Even when using the import block, the same error described in issue #1691 still occurs. Therefore, this is not a shell-related issue. |
@jackofallops |
We are also interested in this fix, please let us know if we can help support at all. |
FIX #1691
Changes
Added
url.PathEscape
to handle special characters in resource IDs.Impact
Resolves parsing errors and improves the reliability of managing Entra ID applications using Terraform.
Breaking Change
This update includes a breaking change.
Users will need to update their configurations to accommodate the new escaping logic for resource IDs.