Skip to content

update cidr in variable networks #36908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update cidr in variable networks #36908

wants to merge 3 commits into from

Conversation

zhengmaowang
Copy link

Fixes #

Target Release

1.13.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry. not sure how to do that.
  • This change is not user-facing.

@zhengmaowang
Update cidr in variable network
3359d6a 
i face the following error when run terraform plan:
│ Error: expected cidr_block to contain a valid network Value, expected 10.1.0.0/16, got 10.1.2.0/16
│ 
│   with aws_vpc.example["dmz"],
│   on main.tf line 47, in resource "aws_vpc" "example":
│   47:   cidr_block = each.value.cidr_block
│ 
╵
╷
│ Error: expected cidr_block to contain a valid network Value, expected 10.1.0.0/16, got 10.1.1.0/16
│ 
│   with aws_vpc.example["public"],
│   on main.tf line 47, in resource "aws_vpc" "example":
│   47:   cidr_block = each.value.cidr_block
@zhengmaowang
Merge pull request #1 from zhengmaowang/zhengmaowang-patch-1
80b3a1e 
Update cidr in variable network
@zhengmaowang zhengmaowang requested review from a team as code owners April 19, 2025 08:39
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Apr 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhengmaowang
Copy link
Author

zhengmaowang commented Apr 21, 2025 •
edited
Loading

I believe this change doesn't need a changelog entry. Could someone please add the no-changelog-needed label for me, it looks like I don't have permission to do that.
i added a changedlog entry. please ignore it.

@zhengmaowang
Copy link
Author

could you please help on the Vercel authorization issue I believe I don't the permission.

@crw crw added documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry labels Apr 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Changelog Warning

Please remove either the 'no-changelog-needed' label or the changelog entry from this PR.

@crw
Copy link
Contributor

crw commented Apr 21, 2025

Thanks for this submission! Can you say something about why you believe this change is necessary? Thanks!

@zhengmaowang
Copy link
Author

Thanks for your reply.

First, I believe the original cidr block is not correct, I face "invalid cidr error" when run "terraform apply" command. It will make the document read more friendly if we change it.

I also test the new cidr block locally and it works after the change. Please let me know if you have any concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhengmaowang @crw