Skip to content

Backport of Validate identity to match identity schema into v1.12 #36938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

Backport of Validate identity to match identity schema into v1.12 #36938

merged 5 commits into from
Apr 29, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport

This PR is auto-generated from #36904 to be assessed for backporting due to the inclusion of the label 1.12-backport.

The below text is copied from the body of the original PR.

This PR adds a new validation that an provider-returned identity conforms to the identity schema.

  • Tests
  • Check if we need to validate this in other places
  • Do we need to check if values aren't null? Is just checking the type conformance enough?

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.
Overview of commits

@github-actions github-actions bot force-pushed the backport/dbanck/validate-identity-matches-schema/preferably-magical-owl branch from 8cb68a7 to 5e2bf05 Compare April 29, 2025 10:03
@github-actions github-actions bot requested a review from dbanck April 29, 2025 10:03
@dbanck dbanck marked this pull request as ready for review April 29, 2025 10:04
@dbanck dbanck requested a review from a team as a code owner April 29, 2025 10:04
@dbanck dbanck added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 29, 2025
@dbanck dbanck merged commit ad84ae8 into v1.12 Apr 29, 2025
9 of 10 checks passed
@dbanck dbanck deleted the backport/dbanck/validate-identity-matches-schema/preferably-magical-owl branch April 29, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@dbanck dbanck

Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @dsa0x