Helm vault namespace do not set if empty #1036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using server side diff with ArgoCD the default provided vault auths for both transit and the default fail to apply. This is because they are set to null when rendered by ArgoCD because the value has not been quoted to take into account for empty strings. ArgoCD will render the namespace as ```yaml namespace: null ``` which fails to apply because the CRD says it must be a string. This fix drops the namespace if its not set, which will fix this error for people using argocd with server side diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using server side diff with ArgoCD the default provided vault auths for both transit and the default fail to apply.
This is because they are set to null when rendered by ArgoCD because the value has not been quoted to take into account for empty strings.
ArgoCD will render the namespace as
which fails to apply because the CRD says it must be a string.
This fix drops the namespace if its not set, which will fix this error for people using argocd with server side diff