Fix VDS bug where 2 leases are being generated on initial deployment #1054
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VaultDynamicSecret is first created, the controller currently performs a sync even though no lease exists yet. This ends up triggering two calls to the Vault API, resulting in two different leases being issued for the same secret. This PR fixes that behavior.
We now short-circuit the initial sync if:
.status.lastGenerationdoesn't match the current object generation (indicating the object hasn't been fully reconciled yet).status.secretLease.idis empty (no lease has been created yet)In this case, we skip the sync logic entirely, just update the status, and wait for the next reconcile loop. This ensures only one lease is created and avoids duplicate users being provisioned by Vault