Support autocomplete with loosely matching candidates

[tom10271]

Versions

v2.23.0

Extension

VS Code

Version: 1.69.0
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:46.408Z (5 days ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin arm64 21.5.0

Operating System

Terraform Version

Terraform v1.2.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v4.27.0

Steps To Reproduce

1. The position after resource should have better autocomplete.
   1. Type gacm, it should list all options contains g, a, c, m sequentially.
   2. When I remove a few characters, it should refresh the list. Currently I need to remove everything before it started to refresh again and I cannot type anything wrong, otherwise it will not work until I remove everything again.

Include any relevant Terraform configuration or project structure:

provider "google" {
  project_id = "salesdatawarehouse-dev"
  region     = "asia-east-2"
}

resource "gooa" "name" { <-- Type gacm, it should list all options contains g, a, c, m sequentially.
  
}

Expected Behavior

Actual Behavior

Additional context

[radeksimko]

Hi @tom10271
It is true that we (only) use exact match when filtering the completion items today.

Just to confirm, am I right you expect the completion items to be filtered using fuzzy search, for example what gopls provides?

[tom10271]

Yes correct. I mainly use JetBrains’ IDE and such feature speed up coding a lot. Not exactly fuzzy search I think? fuzzy search is like if I input lazy, result would contains lazy, lazzy, laazzy, laazz.

[radeksimko]

Right - maybe it doesn't match the strict definition of fuzzy search, I meant more "loose matching", as opposed to exact matching.

Either way that is something that looks useful and something we could implement. Thanks for the suggestion.

[tom10271]

Great to hear that, I am using JetBrains IDE and the plugin there is not working at all, nearly 0% working. Hope we can get a great plugin from VS Code and vastly speed us up which composing the tf files.

There is another issue:

When I remove a few characters, it should refresh the list. Currently I need to remove everything before it started to refresh again and I cannot type anything wrong, otherwise it will not work until I remove everything again.

Should I create another issue for it?

[radeksimko]

There is another issue:

When I remove a few characters, it should refresh the list. Currently I need to remove everything before it started to refresh again and I cannot type anything wrong, otherwise it will not work until I remove everything again.

Should I create another issue for it?

Yes please - if you can create a separate one, and ideally attach a screen recording, that would be amazing! It sounds like a bug and something we could address more easily, compared to implementing loose matching of candidates.

[tom10271]

Yes correct. I mainly use JetBrains’ IDE and such feature speed up coding a lot. 「Radek Simko ***@***.***>」在 2022年7月13日 週三，下午6:37 寫道：

…

Hi @tom10271 <https://github.com/tom10271> It is true that we (only) use exact match when filtering the completion items today <https://github.com/hashicorp/hcl-lang/search?q=HasPrefix>. Just to confirm, am I right you expect the completion items to be filtered using fuzzy search, for example what gopls provides? [image: Screenshot 2022-07-13 at 11 26 22] <https://user-images.githubusercontent.com/287584/178714189-cad83ef1-96e1-4ae6-adad-a9a10c1c1965.png> — Reply to this email directly, view it on GitHub <#1177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG2SXOPX5LVJQRBMXLNRG3VT2L7ZANCNFSM53NCLOCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[FWest98]

Please add support for this. It is the main reason I dislike working on Terraform stuff in VS Code, because I keep having to type the entirety of openstack_networking_ when I just want to add a simple secgroup, for example. Similarly for references, having to type out the entire resource type is very annoying.

[ddmedvedev]

Joining the discussion: Terraform autocomplete in VS Code is weaker compared to JetBrains IDEs.