Skip to content

Conversation

becojo
Copy link
Contributor

@becojo becojo commented Sep 13, 2025

#2101 #2103

Changed default value for terraform.mcp.server.enable from true to false.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Changed default value for terraform.mcp.server.enable from true to false.
@becojo becojo requested a review from a team as a code owner September 13, 2025 16:09
Copy link

hashicorp-cla-app bot commented Sep 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ from team-prodsec, we should disable this option by default.
Thanks @becojo for the PR.

edit after triggering the pipeline: I believe the only thing that is missing to make the CI checks happy is a changelog entry in .changes/unreleased

Copy link
Contributor

@anubhav-goel anubhav-goel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you please add a new changelog entry for this? You can generate it by running changie new and following the prompts. Thanks!

@becojo becojo requested a review from anubhav-goel September 16, 2025 14:43
@anubhav-goel anubhav-goel merged commit 98985d7 into hashicorp:main Sep 17, 2025
13 checks passed
@magnetikonline
Copy link

Great decision - I didn't appreciate an MCP server image magically appearing in my local docker set of images. 👍

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants