Remove snippets file in favor of terraform-ls

.changes/unreleased/ENHANCEMENTS-20240827-150104.yaml

@@ -0,0 +1,6 @@
+kind: ENHANCEMENTS
+body: Remove static snippets
+time: 2024-08-27T15:01:04.207532-04:00
+custom:
+    Issue: "1830"
+    Repository: vscode-terraform

README.md

@@ -106,14 +106,9 @@ See the [Formatting](#formatting) Configuration section for information on how t
 
 ### Code Snippets
 
-The extension provides several snippets to accelerate adding Terraform code to your configuration files:
-
-- `fore` - For Each
-- `module` - Module
-- `output` - Output
-- `provisioner` - Provisioner
-- `vare` - Empty variable
-- `varm` - Map Variable
+The extension provides context aware snippets to accelerate adding Terraform code to your configuration files.
+
+Combined with `editor.suggest.preview` and `terraform.experimentalFeatures.prefillRequiredFields`, the extension can suggest completions for all Terraform language constructs.
 
 ### HCP Terraform Integration
 

package.json

@@ -315,12 +315,6 @@
         }
       }
     },
-    "snippets": [
-      {
-        "language": "terraform",
-        "path": "./snippets/terraform.json"
-      }
-    ],
     "configuration": [
       {
         "title": "General",

src/test/integration/basics/completion.test.ts

@@ -7,15 +7,6 @@ import * as vscode from 'vscode';
 import { assert } from 'chai';
 import { activateExtension, getDocUri, open, testCompletion } from '../../helper';
 
-const snippets = [
-  new vscode.CompletionItem({ label: 'fore', description: 'For Each' }, vscode.CompletionItemKind.Snippet),
-  new vscode.CompletionItem({ label: 'module', description: 'Module' }, vscode.CompletionItemKind.Snippet),
-  new vscode.CompletionItem({ label: 'output', description: 'Output' }, vscode.CompletionItemKind.Snippet),
-  new vscode.CompletionItem({ label: 'provisioner', description: 'Provisioner' }, vscode.CompletionItemKind.Snippet),
-  new vscode.CompletionItem({ label: 'vare', description: 'Empty variable' }, vscode.CompletionItemKind.Snippet),
-  new vscode.CompletionItem({ label: 'varm', description: 'Map variable' }, vscode.CompletionItemKind.Snippet),
-];
-
 suite('completion', () => {
   suite('root document completion', function suite() {
     const docUri = getDocUri('empty.tf');
@@ -49,7 +40,7 @@ suite('completion', () => {
         new vscode.CompletionItem('terraform', vscode.CompletionItemKind.Class),
         new vscode.CompletionItem('variable', vscode.CompletionItemKind.Class),
       ];
-      expected.push(...snippets);
+
       await testCompletion(docUri, new vscode.Position(0, 0), {
         items: expected,
       });
@@ -83,7 +74,6 @@ suite('completion', () => {
         new vscode.CompletionItem('providers', vscode.CompletionItemKind.Property),
         new vscode.CompletionItem('version', vscode.CompletionItemKind.Property),
       ];
-      expected.push(...snippets);
 
       await testCompletion(docUri, new vscode.Position(21, 0), {
         items: expected,
@@ -97,10 +87,6 @@ suite('completion', () => {
         new vscode.CompletionItem('"./compute"', vscode.CompletionItemKind.Text),
       ];
 
-      if (vscode.version <= '1.82.3') {
-        expected.push(...snippets);
-      }
-
       // module "compute" {
       //   source = "./compute"
       //               ^
@@ -166,7 +152,7 @@ suite('completion', () => {
         new vscode.CompletionItem('project', vscode.CompletionItemKind.Property),
         new vscode.CompletionItem('region', vscode.CompletionItemKind.Property),
       ];
-      expected.push(...snippets);
+
       await testCompletion(docUri, new vscode.Position(1, 0), {
         items: expected,
       });