Skip to content

Conversation

@jpogran
Copy link
Contributor

@jpogran jpogran commented Dec 10, 2024

No description provided.

@jpogran jpogran self-assigned this Dec 10, 2024
@jpogran jpogran marked this pull request as ready for review December 11, 2024 14:01
@jpogran jpogran requested a review from a team as a code owner December 11, 2024 14:01
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include some entries from the terraform-ls changelog:

ENHANCEMENTS:

* Stacks: parse terraform-sources.json to support remote component sources ([terraform-ls#1836](https://github.com/hashicorp/terraform-ls/issues/1836))

BUG FIXES:

* Fix incorrect validation for heterogeneous list ([terraform-ls#1884](https://github.com/hashicorp/terraform-ls/issues/1884))
* Fix incorrect validation of references by correctly detecting tuple and object expressions created from for-expressions ([terraform-ls#1890](https://github.com/hashicorp/terraform-ls/issues/1890))

dbanck
dbanck previously approved these changes Dec 12, 2024
jpogran and others added 2 commits December 12, 2024 11:29
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@jpogran jpogran merged commit e478595 into main Dec 12, 2024
13 checks passed
@jpogran jpogran deleted the release_2.34.1 branch December 12, 2024 16:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants