Skip to content

Conversation

@anubhav-goel
Copy link
Contributor

@anubhav-goel anubhav-goel commented Sep 5, 2025

The documentation states that user interactions should happen in the resolveMcpServerDefinition function, so the Docker check is moved over here. The check just sees if the docker info command works. If it fails, it means Docker isn't installed or isn't running.

MCP.Refactor.resolveMcpServerDefinition.mov

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@anubhav-goel anubhav-goel changed the title Refactored: Terraform MCP Server deployment - docker validations & implementation Improve Terraform Configuration for MCP Server using resolveMcpServerDefinition Sep 5, 2025
@anubhav-goel anubhav-goel marked this pull request as ready for review September 5, 2025 18:11
@anubhav-goel anubhav-goel requested a review from a team as a code owner September 5, 2025 18:11
@anubhav-goel anubhav-goel marked this pull request as draft September 5, 2025 18:17
@anubhav-goel anubhav-goel marked this pull request as ready for review September 5, 2025 18:24
@anubhav-goel anubhav-goel merged commit bec90b7 into main Sep 9, 2025
13 checks passed
@anubhav-goel anubhav-goel deleted the feat/TF-28514-MCP-Refactor-resolveMcpServerDefinition branch September 9, 2025 06:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants