-
Notifications
You must be signed in to change notification settings - Fork 188
Configuration option terraform.mcp.server.enable to enable or disable HashiCorp Terraform MCP Server integration
#2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble mcp server config
terraform.mcp.server.enabled to enable or disable HashiCorp Terraform MCP Server integration
jpogran-hashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the suggests, in my testing I noticed something missed in the previous PR.
In the resolveMcpServerDefinition method, we return null if things are not correct. According to the docs, we should be checking if the definition is for our mcp server and returning the original definition if so.
private async resolveMcpServerDefinition(definition: McpServerDefinition): Promise<McpServerDefinition> {
if (definition.label !== 'HashiCorp Terraform MCP Server') {
// Not our definition, return as is
return definition;
}
//
}
terraform.mcp.server.enabled to enable or disable HashiCorp Terraform MCP Server integrationterraform.mcp.server.enable to enable or disable HashiCorp Terraform MCP Server integration
… server, return the server definition
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Screen.Recording.2025-09-09.at.5.37.01.PM.mov
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.