Skip to content

Conversation

@anubhav-goel
Copy link
Contributor

@anubhav-goel anubhav-goel commented Sep 9, 2025

Screen.Recording.2025-09-09.at.5.37.01.PM.mov

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@anubhav-goel anubhav-goel changed the title Added: enable / disable mcp server config Configuration option terraform.mcp.server.enabled to enable or disable HashiCorp Terraform MCP Server integration Sep 9, 2025
@anubhav-goel anubhav-goel marked this pull request as ready for review September 9, 2025 12:09
@anubhav-goel anubhav-goel requested a review from a team as a code owner September 9, 2025 12:09
Copy link
Contributor

@jpogran-hashi jpogran-hashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the suggests, in my testing I noticed something missed in the previous PR.

In the resolveMcpServerDefinition method, we return null if things are not correct. According to the docs, we should be checking if the definition is for our mcp server and returning the original definition if so.

private async resolveMcpServerDefinition(definition: McpServerDefinition): Promise<McpServerDefinition> {
    if (definition.label !== 'HashiCorp Terraform MCP Server') {
      // Not our definition, return as is
      return definition;
    }
    //
  }

@anubhav-goel anubhav-goel changed the title Configuration option terraform.mcp.server.enabled to enable or disable HashiCorp Terraform MCP Server integration Configuration option terraform.mcp.server.enable to enable or disable HashiCorp Terraform MCP Server integration Sep 10, 2025
@anubhav-goel anubhav-goel merged commit f019f7f into main Sep 11, 2025
13 checks passed
@anubhav-goel anubhav-goel deleted the feat/TF-28514-enable-disable-mcp-server branch September 11, 2025 05:37
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants