runInTerminal support #16
Open
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes 'sendRunInTerminalReverseRequest' helper too.
|
@dmjio I'm using this change in the debugger successfully. Perhaps you'd like to review? |
dmjio
requested changes
Sep 30, 2025
| writeToHandle address handle payload | ||
| resetAdaptorStatePayload | ||
| ---------------------------------------------------------------------------- | ||
| -- | Write reverse request to Handle |
There was a problem hiding this comment.
Since reverse requests technically do inherit from ProtocolMesssage, I think it might best if we set the seqNum. It should be possible to define sendReverseRequest in terms of send, and then we'd get this for free.
sendReverseRequest
:: ReverseCommand
-> Adaptor app request ()
sendReverseRequest rcmd = send $ do
setField "type" MessageTypeRequest
setField "command" rcmdIt very well might be true that reverse requests are not subject to sequence numbers, but since it technically inherits ProtocolMesssage it's "the right thing to do".
Then sendRunInTerminalReverseRequest could be
sendRunInTerminalReverseRequest :: RunInTerminalRequestArguments -> Adaptor app request ()
sendRunInTerminalReverseRequest args = do
setField "arguments" args
sendReverseRequest ReverseCommandRunInTerminal| monad-control >= 1.0.3 && < 1.1, | ||
| mtl >= 2.2.2 && < 2.4, | ||
| network >= 3.1.2 && < 3.2, | ||
| network >= 3.1.2 && < 3.3, |
| name = show (typeRep (Proxy @ReverseCommand)) | ||
| ---------------------------------------------------------------------------- | ||
| instance ToJSON ReverseCommand where | ||
| toJSON cmd = genericToJSONWithModifier cmd |
There was a problem hiding this comment.
point free 💅🏼 toJSON = genericToJSONWithModifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15