Use a fake GADT for sequence folds and traversals #1078
+479
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As promised, here's the working draft. It's incomplete and completely unbenchmarked. |
treeowl
commented
Dec 15, 2024
| @@ -1078,7 +1135,33 @@ instance Sized a => Sized (FingerTree a) where | |||
| size (Single x) = size x | |||
| size (Deep v _ _ _) = v | |||
|
|
|||
| -- We don't fold FingerTrees directly, but instead coerce them to | |||
There was a problem hiding this comment.
This is a lie at the moment. It might or might not be true later. WIP....
|
@augustss I'm sure this code is nonsense under MicroHs, but the error message it gives me looks equally nonsensical. |
|
If GHC doesn't complain then MicroHs shouldn't either. I'm happy to take a
bug report.
…On Sun, Dec 15, 2024, 05:26 David Feuer ***@***.***> wrote:
@augustss <https://github.com/augustss> I'm sure this code is nonsense
under MicroHs, but the error message it gives me looks equally nonsensical.
—
Reply to this email directly, view it on GitHub
<#1078 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIARHTII3IMPFIWVETMHG32FUAFXAVCNFSM6AAAAABTUEXLAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGQ2DENZYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It's not just MicroHs, I've never seen GHC react in this many ways to the same piece of code 😀
|
Use in more functions, etc.
|
This still isn't benchmarked, but it's much closer to complete. The main thing I haven't tried applying it to is |
|
@meooow25 Do you have any general thoughts? |
treeowl
force-pushed
the
sequence-folds
branch
2 times, most recently
from
209374c to
8865b01
Compare
treeowl
force-pushed
the
sequence-folds
branch
6 times, most recently
from
b89264c to
95b26ed
Compare
|
Hmm.... Benchmarks are not working out at all. I don't yet know what goes wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.