use stackpane for currency icons

Author: woodser

desktop/src/main/java/haveno/desktop/util/GUIUtil.java

@@ -350,11 +350,10 @@ protected void updateItem(CurrencyListItem item, boolean empty) {
                         default:
 
                             // use icon if available
-                            ImageView currencyIcon = getCurrencyIcon(code);
+                            StackPane currencyIcon = getCurrencyIcon(code);
                             if (currencyIcon != null) {
                                 label1.setText("");
-                                StackPane iconWrapper = new StackPane(currencyIcon); // TODO: icon must be wrapped in StackPane for reliable rendering on linux
-                                label1.setGraphic(iconWrapper);
+                                label1.setGraphic(currencyIcon);
                             }
 
                             if (preferences.isSortMarketCurrenciesNumerically() && item.numTrades > 0) {
@@ -461,11 +460,10 @@ protected void updateItem(TradeCurrency item, boolean empty) {
                         default:
 
                             // use icon if available
-                            ImageView currencyIcon = getCurrencyIcon(code);
+                            StackPane currencyIcon = getCurrencyIcon(code);
                             if (currencyIcon != null) {
                                 label1.setText("");
-                                StackPane iconWrapper = new StackPane(currencyIcon); // TODO: icon must be wrapped in StackPane for reliable rendering on linux
-                                label1.setGraphic(iconWrapper);
+                                label1.setGraphic(currencyIcon);
                             }
 
                             boolean isCrypto = CurrencyUtil.isCryptoCurrency(code);
@@ -506,11 +504,10 @@ protected void updateItem(TradeCurrency item, boolean empty) {
                     label2.getStyleClass().add("currency-label");
 
                     // use icon if available
-                    ImageView currencyIcon = getCurrencyIcon(item.getCode());
+                    StackPane currencyIcon = getCurrencyIcon(item.getCode());
                     if (currencyIcon != null) {
                         label1.setText("");
-                        StackPane iconWrapper = new StackPane(currencyIcon); // TODO: icon must be wrapped in StackPane for reliable rendering on linux
-                        label1.setGraphic(iconWrapper);
+                        label1.setGraphic(currencyIcon);
                     }
 
                     box.getChildren().addAll(label1, label2);
@@ -1283,11 +1280,11 @@ private static <T> void updateEdgeColumnStyleClasses(TableView<T> tableView) {
         return contentColumns;
     }
 
-    public static ImageView getCurrencyIcon(String currencyCode) {
-        return getCurrencyIcon(currencyCode, 24);
+    private static ImageView getCurrencyImageView(String currencyCode) {
+        return getCurrencyImageView(currencyCode, 24);
     }
 
-    public static ImageView getCurrencyIcon(String currencyCode, double size) {
+    private static ImageView getCurrencyImageView(String currencyCode, double size) {
         if (currencyCode == null) return null;
         String imageId = getImageId(currencyCode);
         if (imageId == null) return null;
@@ -1300,19 +1297,24 @@ public static ImageView getCurrencyIcon(String currencyCode, double size) {
         return iconView;
     }
 
+    public static StackPane getCurrencyIcon(String currencyCode) {
+        return new StackPane(getCurrencyImageView(currencyCode));
+    }
+
+    public static StackPane getCurrencyIcon(String currencyCode, double size) {
+        return new StackPane(getCurrencyImageView(currencyCode, size));
+    }
+
     public static StackPane getCurrencyIconWithBorder(String currencyCode) {
         return getCurrencyIconWithBorder(currencyCode, 25, 1);
     }
 
     public static StackPane getCurrencyIconWithBorder(String currencyCode, double size, double borderWidth) {
         if (currencyCode == null) return null;
 
-        ImageView icon = getCurrencyIcon(currencyCode, size);
+        ImageView icon = getCurrencyImageView(currencyCode, size);
         icon.setFitWidth(size - 2 * borderWidth);
         icon.setFitHeight(size - 2 * borderWidth);
-        icon.setPreserveRatio(true);
-        icon.setSmooth(true);
-        icon.setCache(true);
 
         StackPane circleWrapper = new StackPane(icon);
         circleWrapper.setPrefSize(size, size);