show error popup when monerod has 0 peers (unrestricted only)

Author: woodser

core/src/main/java/haveno/core/api/XmrConnectionService.java

@@ -93,7 +93,7 @@ public enum XmrConnectionFallbackType {
     private final MoneroConnectionManager connectionManager;
     private final EncryptedConnectionList connectionList;
     private final ObjectProperty<List<MoneroRpcConnection>> connections = new SimpleObjectProperty<>();
-    private final IntegerProperty numConnections = new SimpleIntegerProperty(0);
+    private final IntegerProperty numConnections = new SimpleIntegerProperty(-1);
     private final ObjectProperty<MoneroRpcConnection> connectionProperty = new SimpleObjectProperty<>();
     private final LongProperty chainHeight = new SimpleLongProperty(0);
     private final DownloadListener downloadListener = new DownloadListener();
@@ -845,6 +845,12 @@ private void doPollMonerod() {
                     return;
                 }
 
+                // set the number of connections which is only availale if not restricted
+                numConnections.set(Boolean.TRUE.equals(lastInfo.isRestricted()) ? -1 : lastInfo.getNumOutgoingConnections());
+                if (numConnections.get() == 0) {
+                    throw new RuntimeException("The Monero node has no connected peers. It may be experiencing a network connectivity issue.");
+                }
+
                 // update properties on user thread
                 UserThread.execute(() -> {
 
@@ -870,7 +876,6 @@ else if (lastInfo.isBusySyncing()) {
                         }
                     }
                     connections.set(availableConnections);
-                    numConnections.set(availableConnections.size());
 
                     // notify update
                     numUpdates.set(numUpdates.get() + 1);

core/src/main/java/haveno/core/app/P2PNetworkSetup.java

@@ -94,7 +94,7 @@ BooleanProperty init(Runnable onReadyHandler, @Nullable Consumer<Boolean> displa
                     if (warning != null && p2pPeers == 0) {
                         result = warning;
                     } else {
-                        String p2pInfo = ((int) numXmrPeers > 0 ? Res.get("mainView.footer.xmrPeers", numXmrPeers) + " / " : "") + Res.get("mainView.footer.p2pPeers", numP2pPeers);
+                        String p2pInfo = ((int) numXmrPeers >= 0 ? Res.get("mainView.footer.xmrPeers", numXmrPeers) + " / " : "") + Res.get("mainView.footer.p2pPeers", numP2pPeers);
                         if (dataReceived && hiddenService) {
                             result = p2pInfo;
                         } else if (p2pPeers == 0)

desktop/src/main/java/haveno/desktop/main/MainView.java

@@ -713,10 +713,9 @@ private AnchorPane createFooter() {
             if (newValue != null) {
                 xmrInfoLabel.setId("splash-error-state-msg");
                 xmrInfoLabel.getStyleClass().add("error-text");
-                if (xmrNetworkWarnMsgPopup == null) {
-                    xmrNetworkWarnMsgPopup = new Popup().warning(newValue);
-                    xmrNetworkWarnMsgPopup.show();
-                }
+                if (xmrNetworkWarnMsgPopup == null)
+                    xmrNetworkWarnMsgPopup = new Popup();
+                xmrNetworkWarnMsgPopup.warning(newValue).show();
             } else {
                 xmrInfoLabel.setId("footer-pane");
                 xmrInfoLabel.getStyleClass().remove("error-text");