fix connection error color mismatch

Author: woodser

core/src/main/java/haveno/core/app/WalletAppSetup.java

@@ -188,6 +188,8 @@ void init(@Nullable Consumer<String> chainFileLockedExceptionHandler,
                             } else {
                                 xmrConnectionService.getConnectionServiceErrorMsg().set(Res.get("mainView.walletServiceErrorMsg.connectionError", exception.getMessage()));
                             }
+                        } else {
+                            xmrConnectionService.getConnectionServiceErrorMsg().set(errorMsg);
                         }
                     }
                     return result;

desktop/src/main/java/haveno/desktop/main/MainView.java

@@ -553,8 +553,15 @@ private VBox createSplashScreen() {
         xmrSplashInfo = new AutoTooltipLabel();
         xmrSplashInfo.textProperty().bind(model.getXmrInfo());
         walletServiceErrorMsgListener = (ov, oldValue, newValue) -> {
-            xmrSplashInfo.setId("splash-error-state-msg");
-            xmrSplashInfo.getStyleClass().add("error-text");
+            UserThread.execute(() -> {
+                if (newValue != null && !newValue.isEmpty()) {
+                    xmrSplashInfo.setId("splash-error-state-msg");
+                    if (!xmrSplashInfo.getStyleClass().contains("error-text")) xmrSplashInfo.getStyleClass().add("error-text");
+                } else {
+                    xmrSplashInfo.setId("");
+                    xmrSplashInfo.getStyleClass().remove("error-text");
+                }
+            });
         };
         model.getConnectionServiceErrorMsg().addListener(walletServiceErrorMsgListener);
 
@@ -710,17 +717,19 @@ private AnchorPane createFooter() {
         //blockchainSyncIndicator.progressProperty().bind(model.getCombinedSyncProgress());
 
         model.getConnectionServiceErrorMsg().addListener((ov, oldValue, newValue) -> {
-            if (newValue != null) {
-                xmrInfoLabel.setId("splash-error-state-msg");
-                xmrInfoLabel.getStyleClass().add("error-text");
-                xmrNetworkWarnMsgPopup = new Popup().warning(newValue);
-                xmrNetworkWarnMsgPopup.show();
-            } else {
-                xmrInfoLabel.setId("footer-pane");
-                xmrInfoLabel.getStyleClass().remove("error-text");
-                if (xmrNetworkWarnMsgPopup != null)
-                    xmrNetworkWarnMsgPopup.hide();
-            }
+            UserThread.execute(() -> {
+                if (newValue != null && !newValue.isEmpty()) {
+                    xmrInfoLabel.setId("splash-error-state-msg");
+                    if (!xmrInfoLabel.getStyleClass().contains("error-text")) xmrInfoLabel.getStyleClass().add("error-text");
+                    xmrNetworkWarnMsgPopup = new Popup().warning(newValue);
+                    xmrNetworkWarnMsgPopup.show();
+                } else {
+                    xmrInfoLabel.setId("footer-pane");
+                    xmrInfoLabel.getStyleClass().remove("error-text");
+                    if (xmrNetworkWarnMsgPopup != null)
+                        xmrNetworkWarnMsgPopup.hide();
+                }
+            });
         });
 
         model.getTopErrorMsg().addListener((ov, oldValue, newValue) -> {