recover when offer reserve tx is invalidated by reorg

Author: woodser

core/src/main/java/haveno/core/offer/OpenOfferManager.java

@@ -1224,17 +1224,21 @@ private MoneroTxWallet getSplitOutputFundingTx(List<OpenOffer> openOffers, OpenO
             MoneroTxWallet splitOutputTx = xmrWalletService.getTx(openOffer.getSplitOutputTxHash());
 
             // check if split output tx is available for offer
-            if (splitOutputTx.isLocked()) return splitOutputTx;
-            else {
-                boolean isAvailable = true;
-                for (MoneroOutputWallet output : splitOutputTx.getOutputsWallet()) {
-                    if (output.isSpent() || output.isFrozen()) {
-                        isAvailable = false;
-                        break;
+            if (splitOutputTx != null) {
+                if (splitOutputTx.isLocked()) return splitOutputTx;
+                else {
+                    boolean isAvailable = true;
+                    for (MoneroOutputWallet output : splitOutputTx.getOutputsWallet()) {
+                        if (output.isSpent() || output.isFrozen()) {
+                            isAvailable = false;
+                            break;
+                        }
                     }
+                    if (isAvailable || isReservedByOffer(openOffer, splitOutputTx)) return splitOutputTx;
+                    else log.warn("Split output tx {} is no longer available for offer {}", openOffer.getSplitOutputTxHash(), openOffer.getId());
                 }
-                if (isAvailable || isReservedByOffer(openOffer, splitOutputTx)) return splitOutputTx;
-                else log.warn("Split output tx is no longer available for offer {}", openOffer.getId());
+            } else {
+                log.warn("Split output tx {} no longer exists for offer {}", openOffer.getSplitOutputTxHash(), openOffer.getId());
             }
         }
 

desktop/src/main/java/haveno/desktop/main/funds/transactions/TransactionsListItem.java

@@ -170,10 +170,6 @@ private LazyFields lazy() {
                     }
                 }
             }
-        } else {
-            if (amount.compareTo(BigInteger.ZERO) == 0) {
-                details = Res.get("funds.tx.noFundsFromDispute");
-            }
         }
 
         // get tx date/time