Application icon missing when installed from deb [0.25 XMR]

[woodser]

This issue requests fixing the missing application icon when installed from deb on Linux:

See the desktop package within the repository: https://github.com/haveno-dex/haveno/tree/master/desktop

[woodser]

Possibly the deb icon was broken by this PR to support the icon for flatpak: #1428

@ohchase Any ideas?

[ohchase]

@woodser hm, I am not sure yet. It would make sense the flatpak icon support could have interfered with this though because I changed the directory structure in the build steps. Initially, I was thinking it would be clear the qualified exchange.haveno.Haveno.png isnt available for the debian package, but the change looks to have accounted for that.

How are you running the debian package? After some reading online, just wanted to make sure the desktop entry file is being loaded from /usr/share/applications. I see mention of the directory structure being important. I can check this later as well

[ohchase]

I pulled a debian build from: https://github.com/haveno-dex/haveno/actions/runs/16883148365
and installed as below (ubuntu 25.04). As you demonstrated the taskbar icon does not show when running this.

Manually adding "StartupWMClass=Haveno" to the desktop entry after installation makes the icon correctly display in the taskbar. I will need to investigate the debian build step and understand why the Haveno.desktop file is not being copied in

[ohchase]

@woodser

Okay so we need to reconsider how we execute debian packaging with jpackage.
For the linux debian build we do not override the resource-dir as we do in windows and mac thus we depend on jpackage to auto generate a desktop entry. The desktop entry being auto generated by jpackage is insufficient in comparison to the explicitly defined desktop entry used in the flatpak and app image packaging.

[woodser]

How are you running the debian package?

I'm installing with

sudo dpkg -i ./haveno-v1.2.0-linux-aarch64-installer.deb 

And then running with

/opt/haveno/bin/Haveno

Hoping to restore the icon for the upcoming release in the next few days, if possible.

I actually tried reverting #1428 and that didn't work to restore the icon surprisingly. 🤔

[github-actions]

There is a bounty on this issue. The amount is in the title. The reward will be awarded to the first person or group of people whose solution is accepted and merged.

In some cases, we may assign the issue to specific contributors. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progress. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

[nabijaczleweli]

Preliminary analysis shows that

1. haveno installs that desktop file (which is different from both desktop files in the repository) into /opt/haveno/lib/haveno-Haveno.desktop,
2. in the postinst it runs xdg-desktop-menu install /opt/haveno/lib/haveno-Haveno.desktop to copy it to /opt/haveno/lib/haveno-Haveno.desktop (this is mirrored in prerm); this goes against policy (https://www.debian.org/doc/debian-policy/ch-opersys.html#menus) which means that it doesn't trigger all the triggers it should probably (on the fresh trixie install I'm testing on this means desktop-file-utils doesn't run update-desktop-database so it's fine probably)

even in that configuration, I get all the icons anyway:

(clean Trixie/MATE default-config install).

@woodser your screenshot looks like the Ubuntu chrome(?); what DE are you using?

[woodser]

what DE are you using?

GNOME

[nabijaczleweli]

Yeah, I repro this on Trixie/GNOME: there is an icon to launch, but it turns into a cog when the app is running:

Contrary to a comment above, appending StartupWMClass=Haveno to haveno-Haveno.desktop did not change it, and neither did copying an adapted desktop/package/linux/Haveno.desktop.

[ohchase]

Yeah, I repro this on Trixie/GNOME: there is an icon to launch, but it turns into a cog when the app is running:

Contrary to a comment above, appending StartupWMClass=Haveno to haveno-Haveno.desktop did not change it, and neither did copying an adapted desktop/package/linux/Haveno.desktop.

Hi can you see if adding the StartupWMClass has a different effect when added to the use/share/applications entry versus the /opt/lib desktop entry.

Additionally could you try using the fully qualified app name for the startup class also

[nabijaczleweli]

Unsurprisingly, editing the /opt/lib .desktop file is equally ineffective.

StartupWMClass=haveno.desktop.app.HavenoApp, as copied from the window title of the EULA, does work.