Skip to content

replace Thread.dumpStack() to write stack traces to log files #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

replace Thread.dumpStack() to write stack traces to log files #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/java/haveno/core/api/XmrConnectionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,8 +654,7 @@ private void maybeStartLocalNode() {
private void onConnectionChanged(MoneroRpcConnection currentConnection) {
if (isShutDownStarted || !accountService.isAccountOpen()) return;
if (currentConnection == null) {
log.warn("Setting daemon connection to null");
Thread.dumpStack();
log.warn("Setting daemon connection to null", new Throwable("Stack trace"));
}
synchronized (lock) {
if (currentConnection == null) {
Expand Down
5 changes: 2 additions & 3 deletions core/src/main/java/haveno/core/trade/protocol/tasks/ArbitratorProcessDepositRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,9 @@ private synchronized void sendDepositResponsesOnce(String errorMessage) {

// log error
if (errorMessage != null) {
log.warn("Sending deposit responses with error={}", errorMessage);
Thread.dumpStack();
log.warn("Sending deposit responses with error={}", errorMessage, new Throwable("Stack trace"));
}

// create deposit response
DepositResponse response = new DepositResponse(
trade.getOffer().getId(),
Expand Down
Loading