Skip to content

Conversation

boldsuck
Copy link
Contributor

  • Update workflow CodeQL Action v2 to v3
  • Update build workflow upload-artifact@v3 to v4
  • Use apt-get in scripts

... and apt interactive ;-)

@boldsuck boldsuck requested a review from woodser as a code owner January 15, 2025 01:54
@boldsuck
Copy link
Contributor Author

boldsuck commented Jan 15, 2025

Damn, I should have rebased to get rid of my merge commits.

actions/runner-images#10636
ubuntu-latest workflows will use Ubuntu-24.04 in a few days. Should we stay on ubuntu-22.04?

@woodser
Copy link
Contributor

woodser commented Jan 15, 2025

We can use 24.02 if there are no build or compatibility problems with it.

@woodser
Copy link
Contributor

woodser commented Jan 15, 2025

Getting an error for Ubuntu 24.04. I'm thinking we should do the Ubuntu update as a separate PR from the other updates.

We can merge this PR right away without the Ubuntu update.

@boldsuck
Copy link
Contributor Author

Getting an error for Ubuntu 24.04. I'm thinking we should do the Ubuntu update as a separate PR from the other updates.

Yeah, 24.04 sucks
https://github.com/boldsuck/haveno/actions

CodeQL, Codacy Coverage Reporter and label.yml are configured with runs-on: ubuntu-latest. I see that you have already changed that to 22.04

label.yml can upgrade from v3 to peter-evans/create-or-update-comment@v4

@woodser woodser merged commit 88b6bed into haveno-dex:master Jan 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants