remove inverted crypto prices; always use price per XMR (base/quote) #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodser
force-pushed
the
deployment3
branch
3 times, most recently
from
3ad4481 to
13900ec
Compare
woodser
changed the title
woodser
force-pushed
the
deployment3
branch
8 times, most recently
from
7ba1189 to
c7dcca0
Compare
woodser
force-pushed
the
deployment3
branch
2 times, most recently
from
788c291 to
35f7b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inverts all crypto prices for consistency with fiat, so that XMR is always the base currency ("price per XMR"), and cryptos are always the counter currency.
For example, XMR/BTC ~= .00295775 BTC per XMR, the same as XMR/USD ~= $318.36 per XMR.
Fixes #1801
Depends on #1815