Skip to content

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Aug 14, 2025

StartupWMClass was "Haveno", which didn't work under GNOME (see screenshots under #1906). Specifying it to be the full class name correctly associates the windows to the icons.

This also merges some non-functional/display-only wording from the hand-written desktop files: Name/GenericName/Comment are fixed from "Haveno"/(not present)/"Haveno".

Closes #1906

@nabijaczleweli nabijaczleweli marked this pull request as ready for review August 14, 2025 19:20
@nabijaczleweli
Copy link
Contributor Author

a b

@woodser
Copy link
Contributor

woodser commented Aug 14, 2025

Hm, I installed it with:

sudo dpkg -i ~/Downloads/haveno-v1.2.0-linux-aarch64-installer.deb 

And run it with:

/opt/haveno/bin/Haveno

But for some reason still missing the icon:

image

Hopefully you are able to see the same. I'm running Ubuntu 24.02.

@nabijaczleweli
Copy link
Contributor Author

nabijaczleweli commented Aug 14, 2025

I can't reproduce this on GNOME (dpkg -i, no additional postprocessing, but launching from the launcher since launching directly fails mentioning $DESKTOP). I'll try installing Ubuntu.

@nabijaczleweli
Copy link
Contributor Author

Default settings fresh Ubuntu 25: app search, launched from app search, launched from xterm:

a b c

This is the type of thing that feels like it would be affected by running xorg vs xwayland? So I logged into "Ubuntu with Xorg" and it also works there:

d e

I'm using the deb from https://github.com/haveno-dex/haveno/actions/runs/16974013546?pr=1917 for testing (and unpacking shows that both arches have StartupWMClass=haveno.desktop.app.HavenoApp), are you sure you got the right debs?

@woodser woodser merged commit 3067609 into haveno-dex:master Aug 15, 2025
7 checks passed
@woodser
Copy link
Contributor

woodser commented Aug 15, 2025

It's working :). There was some problem with my Ubuntu VM, but it works fine on a fresh install.

Please reply or DM an address for payout. Thanks for your help.

@nabijaczleweli
Copy link
Contributor Author

I really shudder to think what the problem could actually be in that case 🥴

Please pay out to 8AwxUe2fLirDBiAceJW4CD3zu4xHai4LWMkx3YjDqzMBTuQuueCzEmY2pjZHjJu3yiZr5skAUpWNqR7xmRpSsv3YEjki7GT

@woodser
Copy link
Contributor

woodser commented Aug 15, 2025

Guessing it was just some caching issue with the icon. I found that Ubuntu caches icons aggressively, and needed to clear some caches on my fresh VM install in order to update the icon there too.

Payout made. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application icon missing when installed from deb [0.25 XMR]
2 participants