Skip to content

fix error reopening clone offer tab after changing tabs #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2025
Merged

fix error reopening clone offer tab after changing tabs #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions desktop/src/main/java/haveno/desktop/main/portfolio/PortfolioView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public class PortfolioView extends ActivatableView<TabPane, Void> {
private boolean editOpenOfferViewOpen, cloneOpenOfferViewOpen;
private OpenOffer openOffer;
private OpenOffersView openOffersView;
private boolean tabListChangeListenerAdded = false;

@Inject
public PortfolioView(CachingViewLoader viewLoader, Navigation navigation, FailedTradesManager failedTradesManager) {
Expand Down Expand Up @@ -168,7 +169,10 @@ protected void activate() {
root.getTabs().add(failedTradesTab);

root.getSelectionModel().selectedItemProperty().addListener(tabChangeListener);
root.getTabs().addListener(tabListChangeListener);
if (!tabListChangeListenerAdded) {
root.getTabs().addListener(tabListChangeListener);
tabListChangeListenerAdded = true; // add listener only once
}
navigation.addListener(navigationListener);

if (root.getSelectionModel().getSelectedItem() == openOffersTab)
Expand All @@ -194,7 +198,6 @@ else if (root.getSelectionModel().getSelectedItem() == editOpenOfferTab) {
@Override
protected void deactivate() {
root.getSelectionModel().selectedItemProperty().removeListener(tabChangeListener);
root.getTabs().removeListener(tabListChangeListener);
navigation.removeListener(navigationListener);
currentTab = null;
}
Expand Down
Loading