Cilium Value Override

[EssamEmad]

TL;DR

There's no easy way to override Cilium values without boilerplate. Should we add cilium_values_override to variables.tf?

Problem

Hello! Thanks for the great library!
The library provisions Talos in an opinionated way where it uses Cilium as a default CNI. This is good as Cilium provides a lot of benefits to a K8s cluster. However, when trying to extend Cilium further, boilerplate unnecessarily increases because the library either uses the default or drop the defaults in favour of user-generated cilium values. Is there an easy way to provide a single override (something like gatewayAPI.enabled = true)?

Proposition

If there isn't, does it make sense to add something like cilium_overrides which get merged with the cilium_defaults? If this looks like a reasonable direction, I can send a PR.

[mrclrchtr]

Hi, thanks for reaching out.

I'm using the values file of the cilium helm chart, to overwrite the default values and use the exact values, that gets deployed by ArgoCD later:

cilium_values = [templatefile("../../../core/kube-system/cilium/values.yaml", {})]

But yes, I think the possibility to override would be a nice enhancement.

You are welcome to do a PR.

[EssamEmad]

I created PR #281 that addresses the underlying issue behind this issue. I added context in the PR. Could you take a look please?

Thanks