Skip to content

fix(deps): fixing dependency conflict#14

Open
samber wants to merge 1 commit intohcompai:mainfrom
samber:fix/fix-dependency-conflict
Open

fix(deps): fixing dependency conflict#14
samber wants to merge 1 commit intohcompai:mainfrom
samber:fix/fix-dependency-conflict

Conversation

@samber
Copy link

@samber samber commented Mar 9, 2026

Fixes #13

Copilot AI review requested due to automatic review settings March 9, 2026 16:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves the dependency conflict reported in #13 by removing unused transformers/vllm from the project’s core dependency set in pyproject.toml.

Changes:

  • Removed transformers and vllm from pyproject.toml dependencies to eliminate their version conflict.
  • Relaxed the pillow version constraint by removing the upper bound.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dependencies = [
"openai>=1.93.0",
"pillow>=8,<=11.1",
"pillow>=8",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pillow>=8 is too permissive for the current codebase: multiple modules call Image.Resampling.LANCZOS, which is not available in older Pillow releases. Please raise the lower bound to a version that guarantees Image.Resampling support (and ideally align it with requirements.txt, which already requires pillow>=11.1.0).

Suggested change
"pillow>=8",
"pillow>=11.1.0",

Copilot uses AI. Check for mistakes.
"pillow>=8,<=11.1",
"pillow>=8",
"pydantic>=2.0",
"selenium>=4.28.1",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transformers/vllm were removed from pyproject.toml, but the committed uv.lock still contains locked entries/specifiers for both. Regenerate/update uv.lock so the lockfile reflects the new dependency set and installs remain reproducible.

Suggested change
"selenium>=4.28.1",
"selenium>=4.28.1",
"transformers",
"vllm",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between dependencies

2 participants