Format BCE dates correctly

Author: mjradwin

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hebcal/rest-api",
-  "version": "3.4.0",
+  "version": "3.4.1",
   "author": "Michael J. Radwin (https://github.com/mjradwin)",
   "keywords": [
     "hebcal"
@@ -21,7 +21,7 @@
     "url": "https://github.com/hebcal/hebcal-rest-api/issues"
   },
   "dependencies": {
-    "@hebcal/core": "^3.17.0",
+    "@hebcal/core": "^3.17.3",
     "@hebcal/geo-sqlite": "^3.4.1",
     "@hebcal/leyning": "^4.4.0"
   },
@@ -61,7 +61,7 @@
     "@rollup/plugin-node-resolve": "^13.0.0",
     "ava": "^3.15.0",
     "core-js": "^3.12.1",
-    "eslint": "^7.26.0",
+    "eslint": "^7.27.0",
     "eslint-config-google": "^0.14.0",
     "jsdoc": "^3.6.7",
     "jsdoc-to-markdown": "^5.0.3",

src/classic-rest-api.spec.js

@@ -79,6 +79,25 @@ test('eventToClassicApiObject', (t) => {
   t.deepEqual(shavuotActual, shavuotExpected);
 });
 
+test('bce', (t) => {
+  const options = {
+    start: new Date(-1, 4, 6),
+    end: new Date(-1, 4, 6),
+    il: false,
+  };
+  const ev = HebrewCalendar.calendar(options)[0];
+  const apiObj = eventToClassicApiObject(ev, options);
+  const expected = {
+    title: 'Erev Shavuot',
+    date: '-00001-05-06',
+    category: 'holiday',
+    subcat: 'major',
+    hebrew: 'ערב שבועות',
+    memo: 'Festival of Weeks. Commemorates the giving of the Torah at Mount Sinai',
+  };
+  t.deepEqual(apiObj, expected);
+});
+
 test('eventsToClassicApi', (t) => {
   const location = Location.lookup('Vancouver');
   const options = {

src/common.js

@@ -54,7 +54,9 @@ export function pad2(number) {
  * @return {string}
  */
 export function pad4(number) {
-  if (number < 10) {
+  if (number < 0) {
+    return '-0' + pad4(-number);
+  } else if (number < 10) {
     return '000' + number;
   } else if (number < 100) {
     return '00' + number;

src/fullcalendar.spec.js

@@ -214,3 +214,22 @@ test('fastStartEnd', (t) => {
   ];
   t.deepEqual(fc, expected);
 });
+
+test('bce', (t) => {
+  const options = {
+    start: new Date(-1, 4, 6),
+    end: new Date(-1, 4, 6),
+    il: false,
+  };
+  const ev = HebrewCalendar.calendar(options)[0];
+  const fc = eventToFullCalendar(ev);
+  const expected = {
+    title: 'Erev Shavuot',
+    start: '-00001-05-06',
+    allDay: true,
+    className: 'holiday major',
+    hebrew: 'ערב שבועות',
+    description: 'Festival of Weeks. Commemorates the giving of the Torah at Mount Sinai',
+  };
+  t.deepEqual(fc, expected);
+});

src/rss.js

@@ -13,7 +13,8 @@ function getLinkAndGuid(ev, il, mainUrl) {
   let guid;
   const dt = ev.eventTime || ev.getDate().greg();
   const dtStr0 = dt.toISOString();
-  const dtStr = encodeURIComponent(dtStr0.substring(0, ev.eventTime ? 19 : 10));
+  const timeIdx = dtStr0.indexOf('T');
+  const dtStr = encodeURIComponent(dtStr0.substring(0, ev.eventTime ? timeIdx + 9 : timeIdx));
   const url0 = ev.url();
   const url = appendIsraelAndTracking(url0 || mainUrl, il, 'shabbat1c', 'rss').replace(/&/g, '&');
   if (url0) {
@@ -98,7 +99,8 @@ export function eventToRssItem(ev, evPubDate, lastBuildDate, dayFormat, location
   let subj = ev.render();
   const evDate = ev.getDate().greg();
   const pubDate = getPubDate(ev, evPubDate, evDate, lastBuildDate);
-  const linkGuid = getLinkAndGuid(ev, location.getIsrael(), mainUrl);
+  const il = location ? location.getIsrael() : false;
+  const linkGuid = getLinkAndGuid(ev, il, mainUrl);
   const link = linkGuid[0];
   const guid = linkGuid[1];
   const description = dayFormat.format(evDate);
@@ -109,7 +111,7 @@ export function eventToRssItem(ev, evPubDate, lastBuildDate, dayFormat, location
   if (candles) {
     const colon = subj.indexOf(': ');
     if (colon != -1) {
-      const options = {location, il: location.getIsrael(), locale: Locale.getLocaleName()};
+      const options = {location, il, locale: Locale.getLocaleName()};
       const time = HebrewCalendar.reformatTimeStr(ev.eventTimeStr, 'pm', options);
       subj = subj.substring(0, colon) + ': ' + time;
     }