-
-
Notifications
You must be signed in to change notification settings - Fork 366
ifNth arguments seem to be switched #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The following test shows an example of the usage: handlebars-helpers/test/comparison.js Lines 381 to 401 in 20a2fa1
I agree that the documentation could be updated to show an example and clear up which is argument is dividing the other. Would you like to do a PR to update the code comments? I think the logic is correct because the usage in the test "feels" more natural to me. |
Sure, landed here: #307. |
handlebars-helpers/lib/comparison.js
Line 328 in 5d3405f
Is there any idea behind switching arguments (
b % a
) here? Documentation says thatbut logic seems to be inverse. I spent plenty of time trying to figure out why my
ifNth
is not working as supposed, or I just don't get it.The text was updated successfully, but these errors were encountered: