Skip to content

Commit 94e6d9d

Browse files
authored
Do not propagate -Werror from leveldb (#1583)
Setting -Werror as PUBLIC flag means that all targets that link to leveldb will stop compiling on the first warning. An intermediate library must never propagate that flag to parent projects. Relates-To: MINOR Signed-off-by: Harald Fernengel <harald.fernengel@here.com>
1 parent 5b71421 commit 94e6d9d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

external/leveldb/CMakeLists-leveldb.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,10 @@ endif(BUILD_SHARED_LIBS)
247247
if(HAVE_CLANG_THREAD_SAFETY)
248248
target_compile_options(leveldb
249249
PUBLIC
250-
-Werror -Wthread-safety)
250+
-Wthread-safety
251+
PRIVATE
252+
-Werror
253+
)
251254
endif(HAVE_CLANG_THREAD_SAFETY)
252255

253256
if(HAVE_CRC32C)

0 commit comments

Comments
 (0)