Skip to content

Commit cafa3ba

Browse files
authored
Hotfix 1.11.1 (#475)
This CR fixes the error on the compilation phase, related to the type checking. We import the module `fs` only for nodejs, it's configured in the package.json file, so we can disable the type checking for the importing in the private class NodeFileData and it's safe. Updated versions and CHANGELOG Resolves: OLPSUP-14784 Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
1 parent 51b7fb7 commit cafa3ba

File tree

7 files changed

+246
-226
lines changed

7 files changed

+246
-226
lines changed

@here/olp-sdk-authentication/test/OAuth.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe("oauth-request-offline", function() {
9494

9595
const options: RequestInit & any = fetchMock.calls()[0][1];
9696
expect(options.headers.get("Authorization")).to.be.equal(
97-
`OAuth oauth_consumer_key="mocked-key",oauth_nonce="mocked-nonce",oauth_signature_method="HMAC-SHA256",oauth_timestamp="1550777140",oauth_version="1.0",oauth_signature="v4mS3w5P0ba%2FBmgK2XfS8VzPFy2mUm%2FCZT0KvimSQxo%3D"`
97+
`OAuth oauth_consumer_key="mocked-key",oauth_nonce="mocked-nonce",oauth_signature_method="HMAC-SHA256",oauth_timestamp="1550777140",oauth_version="1.0",oauth_signature="PVYijMWSDplONd9abHA8rx3OuHB7NkxfQqE2jw3I%2FE0%3D"`
9898
);
9999
});
100100

@here/olp-sdk-core/lib.version.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20-
export const LIB_VERSION = "1.11.0";
20+
export const LIB_VERSION = "1.11.1";

@here/olp-sdk-core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"name": "@here/olp-sdk-core",
3-
"version": "1.6.0",
3+
"version": "1.6.1",
44
"description": "Core features of the HERE Data Platform",
55
"main": "index.js",
66
"browser": "index.web.js",
7-
"typings": "index",
7+
"typings": "index.web",
88
"directories": {
99
"test": "test",
1010
"lib": "lib"

@here/olp-sdk-dataservice-write/lib/utils/multipartupload-internal/NodeFileData.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20-
import { fs } from "@here/olp-sdk-core";
2120
import { BlobData } from "@here/olp-sdk-dataservice-write";
2221

22+
// @ts-ignore disable typechecking for this line
23+
import { fs } from "@here/olp-sdk-core";
24+
2325
/**
2426
* @internal
2527
* Implementation of reading bytes from file by filepath

@here/olp-sdk-dataservice-write/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@here/olp-sdk-dataservice-write",
3-
"version": "1.6.0",
3+
"version": "1.6.1",
44
"description": "Wrapper around a subset of the HERE Open Location Platform Data REST API related to writing data to OLP catalogs",
55
"main": "index.js",
66
"browser": "index.web.js",

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## v1.11.1 (17/06/2021)
2+
3+
**olp-sdk-dataservice-write**
4+
5+
- Disable type checking for line `import { fs } from "@here/olp-sdk-core";` in `NodeFileData` private class.
6+
7+
**olp-sdk-core**
8+
9+
- Change typings settings to `index.web`.
10+
111
## v1.11.0 (07/06/2021)
212

313
**olp-sdk-dataservice-write**

yarn.lock

Lines changed: 228 additions & 220 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)