Skip to content

Support virtio-fs on MMIO #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hcsch opened this issue Apr 22, 2025 · 4 comments
Open

Support virtio-fs on MMIO #1692

hcsch opened this issue Apr 22, 2025 · 4 comments
Assignees

Comments

@hcsch
Copy link

hcsch commented Apr 22, 2025

The non-transport specific parts of the VIRTIO filesystem driver are feature gated on pci, even though they are not transport specific and even contain PCI and non-PCI feature gated types internally.

#[cfg(feature = "pci")]
pub mod virtio_fs;

#[cfg(not(feature = "pci"))]
use crate::drivers::virtio::transport::mmio::{ComCfg, IsrStatus, NotifCfg};
#[cfg(feature = "pci")]
use crate::drivers::virtio::transport::pci::{ComCfg, IsrStatus, NotifCfg};

@hcsch
Copy link
Author

hcsch commented Apr 22, 2025

I might have been a bit too much in an issue opening spree, sorry. It seems this was intentionally done in b5a45e2 to hide VIRTIO fs when the PCI feature has not been selected.

@hcsch hcsch closed this as completed Apr 22, 2025
@mkroening
Copy link
Member

I think that was done to please clippy. Integrating and enabling virtio-fs on MMIO would be good. 👍

@mkroening mkroening reopened this Apr 22, 2025
@mkroening mkroening changed the title Too restrictive feature gating of VIRTIO filesystem module Support virtio-fs on MMIO Apr 22, 2025
@elise-insall
Copy link

Hello, I'm a student taking virtualization at UT Austin. Our class requires us to contribute to an open source project. Can my group and I take this one?

@mkroening
Copy link
Member

Sure, go ahead!

If you have any questions, feel free to ask them here or chat with us on our Zulip. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants