Skip to content

feat: always log targets #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: always log targets #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ fuse = ["virtio", "pci", "dep:fuse-abi", "fuse-abi/num_enum"]
gem-net = ["net", "dep:tock-registers"]
idle-poll = []
kernel-stack = []
log-target = []
net = []
mman = []
mmap = ["mman"] # Deprecated in favor of mman
Expand Down
9 changes: 3 additions & 6 deletions src/logging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ impl log::Log for KernelLogger {
};
let core_id = crate::arch::core_local::core_id();
let level = ColorLevel(record.level());
// FIXME: Use `super let` once stable

let target = record.target();
let (crate_, modules) = target.split_once("::").unwrap_or((target, ""));
let (_modules, module) = modules.rsplit_once("::").unwrap_or(("", modules));
Expand All @@ -60,11 +60,8 @@ impl log::Log for KernelLogger {
} else {
crate_
};
let format_target = if cfg!(feature = "log-target") {
format_args!(" {target:<10}")
} else {
format_args!("")
};
let format_target = format_args!(" {target:<10}");

let args = record.args();
println!("{format_time}[{core_id}][{level}{format_target}] {args}");
}
Expand Down