feat: add set_node_account_ids to the query chain#1727
Conversation
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughPins receipt queries in TransactionResponse.get_receipt() to the submitting node by calling Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant TxResponse as TransactionResponse
participant ReceiptQ as TransactionGetReceiptQuery
participant NodeA as "Node 0.0.3"
participant NodeB as "Node 0.0.4"
Client->>TxResponse: response.get_receipt(client)
TxResponse->>ReceiptQ: new TransactionGetReceiptQuery()
ReceiptQ->>ReceiptQ: .set_transaction_id(txId)
ReceiptQ->>ReceiptQ: .set_node_account_ids([submittingNode])
ReceiptQ->>NodeA: execute(query)
alt NodeA returns non-retryable error
NodeA-->>ReceiptQ: error
ReceiptQ-->>Client: error (pinned to submitting node)
else NodeA returns SUCCESS
NodeA-->>ReceiptQ: receipt SUCCESS
ReceiptQ-->>Client: receipt SUCCESS
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
tech0priyanshu
left a comment
There was a problem hiding this comment.
Hii @AntonioCeppellini great work done ... lgtm
|
some merge conflict @AntonioCeppellini |
manishdait
left a comment
There was a problem hiding this comment.
lgtm, just needs a rebase
…g-node-by-default Signed-off-by: AntonioCeppellini <128388022+AntonioCeppellini@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1727 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 141 141
Lines 9116 9116
=======================================
Hits 8505 8505
Misses 611 611 🚀 New features to boost your workflow:
|
|
just chagelog entry please |
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com>
aceppaluni
left a comment
There was a problem hiding this comment.
@AntonioCeppellini Great work!
Once rebased, happy to approve and merge!
…g-node-by-default Signed-off-by: AntonioCeppellini <128388022+AntonioCeppellini@users.noreply.github.com>
this is address in the PR #1769 |
|
Hello, this is the OfficeHourBot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here for any changes. From, |
Signed-off-by: Antonio Ceppellini <antonio.ceppellini@gmail.com> Signed-off-by: AntonioCeppellini <128388022+AntonioCeppellini@users.noreply.github.com>
Description:
This PR updates
TransactionResponse.get_receipt()addingset_node_account_ids([self.node_id])to the query chainwe now
self.node_id)Related issue(s):
Fixes #1686
Notes for reviewer:
Checklist