docs: add ScheduleDeleteTransaction
#527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
SimiHunjan
reviewed
Aug 27, 2025
|
|
||
| | Test no | Name | Input | Expected response | Implemented (Y/N) | | ||
| |---------|----------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------|-------------------| | ||
| | 1 | Deletes a scheduled transaction | scheduleId=<CREATED_SCHEDULE_ID>, commonTransactionParams.signers=[<CREATED_SCHEDULE_ADMIN_KEY>] | The schedule deletion succeeds and the transaction is no longer scheduled. | N | |
There was a problem hiding this comment.
should we have individual tests for scheduling each transaction type and deleting them?
There was a problem hiding this comment.
I don't know how much value that'd bring. Once the transaction is already scheduled, delete doesn't care what transaction it is, just if the ID is valid
SimiHunjan
reviewed
Aug 27, 2025
| | 4 | Deletes a scheduled transaction with an empty schedule ID | scheduleId="" | The schedule deletion fails with an internal SDK error. | N | | ||
| | 5 | Deletes a scheduled transaction with no schedule ID | | The schedule deletion fails with an `INVALID_SCHEDULE_ID` response code from the network. | N | | ||
| | 6 | Deletes a scheduled transaction that has already been deleted | scheduleId=<DELETED_SCHEDULE_ID>, commonTransactionParams.signers=[<DELETED_SCHEDULE_ADMIN_KEY>] | The schedule deletion fails with a `SCHEDULE_ALREADY_DELETED` response code from the network. | N | | ||
| | 7 | Deletes a scheduled transaction without signing with the admin key | scheduleId=<CREATED_SCHEDULE_ID> | The schedule deletion fails with an `INVALID_SIGNATURE` response code from the network. | N | |
There was a problem hiding this comment.
what about an ID that like 0.0.hsois9397 or something? Or SDK doesn't even allow you to enter that?
There was a problem hiding this comment.
SDK wouldn't allow it and would be an internal SDK error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the test specifications for
ScheduleDeleteTransactionRelated issue(s):
Fixes #118