epic(37322): Add search and filter to the workspace #1212
Merged
+3,890
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
epic/37055-workspace-operations
branch
from
f001984 to
5dfe683
Compare
Test Results 461 files 461 suites 3m 56s ⏱️ Results for commit 8cab819. ♻️ This comment has been updated with latest results. |
Coverage Report
|
vanch3d
changed the title
vanch3d
force-pushed
the
epic/37055-workspace-operations
branch
from
6cee54d to
4bff971
Compare
codepitbull
force-pushed
the
epic/37055-workspace-operations
branch
from
4bff971 to
b01bf14
Compare
vanch3d
force-pushed
the
epic/37055-workspace-operations
branch
2 times, most recently
from
82e78b4 to
cdd15bb
Compare
* feat(37055): add the search toolbox * feat(37055): add a toolbar for the canvas * feat(37055): add variant for the form control * refactor(37055): add options for the react-flow fitview * fix(37055): fix bug * fix(37055): fix translations * chore(37055): a bit of cleaning * test(37055): add tests * refactor(37055): remove the internal state and add callback for chang… * test(37055): add tests * chore(37055): trigger ci * fix(37055): fix bug with state/count * fix(37055): fix translations * test(37055): fix tests * fix(37055): a bit of cleaning
* Merge pull request #1213 * feat(37057): add a toolbox for the filters * feat(37057): add filter types * feat(37057): add filter for status * feat(37057): add filter for selection * feat(37057): add filter for entities * feat(37057): add filter for topics * feat(37057): add options for filter * feat(37057): add apply/clear actions for filters * feat(37057): add component for save/load filter configuration * refactor(37057): refactor the filter popover * refactor(37057): add translations * refactor(37057): add filter utilities * fix(37057): fix portal * refactor(37057): update layout * refactor(37057): update storage keys * refactor(37057): change popover into drawer * refactor(37057): fix translations * refactor(37057): refactor the options of the join * fix(37057): fix overlay for confirmation * refactor(37057): refactor the CTAs * refactor(37057): add custom filters and components * refactor(37057): refactor props and ids * refactor(37057): add types * refactor(37057): refactor the drawer * feat(37057): add support for protocol filtering * refactor(37057): fix status * refactor(37057): add activation wrapper for filters * feat(37057): add quick filters * refactor(37057): fix style * refactor(37057): fix translations * refactor(37057): change layout * feat(37057): add routine for multi-criteria filtering * test(37057): add tests * test(37057): add tests * test(37057): add tests * test(37057): add tests * test(37057): add tests * test(37057): add tests * feat(37057): add toolbar * fix(37057): fix types * refactor(37057): refactor filtering options * refactor(37057): add callbacks * test(37057): add tests * test(37057): add tests * fix(37057): fix translations * fix(37057): fix rebase * fix(36682): fix linting * refactor(37057): refactor the quick filter save component * test(37057): add test * fix(37057): fix translations * fix(37057): fix layout * fix(37057): fix types and prop names * fix(37057): fix types * fix(37057): fix layout * refactor(37057): add handles for save and activate * refactor(37057): refactor the callbacks * refactor(37057): refactor the handling of a new quick filter * test(37057): add tests * refactor(37057): update translations * chore(37057): trigger ci pipeline * fix(37057): fix accessibility * fix(37057): fix tranlations * fix(37057): fix test * fix(37057): fix QA review issues * fix(37057): fix tests * test(37057): add tests * fix(37057): a bit of cleaning * fix(37057): fix the type
* refactor(37430): refactor the horizontal variant for form controls * refactor(37430): fix the layout * refactor(37430): fix the layout * feat(37430): add collapse/expand feature to the search toolbar * feat(37430): update translations * refactor(37430): disable editing * refactor(37430): change the visibility of quick filters when new one … * refactor(37430): apply quick filters to the canvas * feat(37430): add support routines for quick filters * test(37430): fix tests * test(37430): fix tests * test(37430): fix tests * fix(37430): a bit of cleaning * test(37430): add tests * test(37430): fix tests * refactor(37430): refactor theme * chore(37430): a bit of cleaning
vanch3d
force-pushed
the
epic/37055-workspace-operations
branch
from
cdd15bb to
7628e4e
Compare
* refactor(37696): update types * refactor(37696): update types * refactor(37696): add disabled state to criteria * refactor(37696): add disabled state * refactor(37696): disable the integration point criteria * chore(37696): update dependencies * chore(37696): trigger ci * refactor(37696): add disabled state * test(37696): add tests * chore(37696): add context * test(37696): fix tests * fix(37696): fix state * chore(37696): linting
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive search and filter functionality to the workspace, enabling users to find and filter entities (adapters, bridges, devices) by various criteria including entity type, protocol, status, and selection. The implementation includes a collapsible toolbar with search capabilities, a filter drawer with multiple criteria options, and quick filter management.
Key Changes:
- Added search functionality with entity navigation
- Implemented multi-criteria filtering system with OR/AND logic support
- Created quick filter configuration management with localStorage persistence
Reviewed Changes
Copilot reviewed 68 out of 69 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
hivemq-edge-frontend/src/modules/Workspace/utils/react-flow.utils.ts |
Added shared fitView configuration constant |
hivemq-edge-frontend/src/modules/Workspace/components/filters/* |
New filter components including search, criteria editors, and filter management |
hivemq-edge-frontend/src/modules/Workspace/components/controls/CanvasToolbar.tsx |
New collapsible toolbar with search and filter integration |
hivemq-edge-frontend/src/modules/Workspace/components/ReactFlowWrapper.tsx |
Integrated new toolbar into workspace canvas |
hivemq-edge-frontend/src/modules/Theme/components/FormControl.ts |
Added horizontal form control variant for filter layouts |
hivemq-edge-frontend/src/locales/en/translation.json |
Added translations for search and filter features |
Various test files (*.spec.cy.tsx) |
Comprehensive component and integration tests |
Files not reviewed (1)
- hivemq-edge-frontend/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hivemq-edge-frontend/src/modules/Workspace/components/filters/filters.utils.ts
Show resolved
Hide resolved
hivemq-edge-frontend/src/modules/Workspace/components/filters/ConfigurationSave.tsx
Show resolved
Hide resolved
hivemq-edge-frontend/src/modules/Workspace/components/filters/OptionsFilter.tsx
Show resolved
Hide resolved
hivemq-edge-frontend/src/modules/Workspace/components/filters/filters.utils.ts
Show resolved
Hide resolved
hivemq-edge-frontend/src/modules/Workspace/components/filters/DrawerFilterToolbox.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/37322/details/