Skip to content

[fix #81] replace grid.newpage with grid.null #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix #81] replace grid.newpage with grid.null #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import(utils)
importFrom(grid,gpar)
importFrom(grid,grid.draw)
importFrom(grid,grid.layout)
importFrom(grid,grid.newpage)
importFrom(grid,grid.null)
importFrom(grid,legendGrob)
importFrom(grid,popViewport)
importFrom(grid,pushViewport)
Expand Down
8 changes: 4 additions & 4 deletions R/UpSet.plot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#' @importFrom grid grid.newpage
#' @importFrom grid grid.null
#' @importFrom grid pushViewport
#' @importFrom grid viewport
#' @importFrom grid grid.layout
Expand Down Expand Up @@ -108,7 +108,7 @@ BaseBoxPlot <- function(box_plot, position, size_plot_height, Main_bar_plot, Mat
metadata_right <- set_metadata$ncols
metadata_left <- 1
}
grid.newpage()
grid.null()
if(length(box_plot) == 1){
pushViewport(viewport(layout = grid.layout(135,matrix_and_mainbar_right)))
}
Expand Down Expand Up @@ -184,7 +184,7 @@ NoAttBasePlot <- function(legend, size_plot_height, Main_bar_plot, Matrix_plot,
metadata_right <- set_metadata$ncols
metadata_left <- 1
}
grid.newpage()
grid.null()
if((is.null(legend) == F) && (query_legend != tolower("none"))){
if(query_legend == tolower("top")){
pushViewport(viewport(layout = grid.layout(102, matrix_and_mainbar_right)))
Expand Down Expand Up @@ -259,7 +259,7 @@ BaseCustomPlot <- function(attribute_plots, plots, position, size_plot_height, M
custom_top <- custom_top + 5
custom_bottom <- custom_bottom + 5
}
grid.newpage()
grid.null()
pushViewport(viewport(layout = grid.layout(custom_bottom,matrix_and_mainbar_right)))
vp = vplayout(bar_top:matrix_bottom, matrix_and_mainbar_left:matrix_and_mainbar_right)
pushViewport(vp)
Expand Down