PacketEncoder: add minimal validation of fcgi packets on decode #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event infinite loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When accidentally contacting a HTTP server instead of an fcgi server, Socket::readPacket() can turn into an infinite loop. This change implements a rudimentary check that the server that was contacted is actually a fcgi server.
Further comments
A proper fix would also implement a global timeout in Socket::readPacket(). On top of that, stream_select() or similar should be used in the while ( $length && ($buffer = fread loop so that it does not run as a busy loop, but I was unable to convince it to block with the HTTP server that caused the initial problem.