Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Tracing dm#2107

Open
freesig wants to merge 8 commits into
developfrom
tracing-dm
Open

Tracing dm#2107
freesig wants to merge 8 commits into
developfrom
tracing-dm

Conversation

@freesig
Copy link
Copy Markdown
Contributor

@freesig freesig commented Feb 12, 2020

PR summary

This adds tracing so I plan for this PR to be small and merged quickly to avoid conflicts 🚀
Adds neater traces to capture direct messages.
Before merge:

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@freesig freesig changed the base branch from develop to tracing-1 February 12, 2020 20:48
@freesig freesig changed the base branch from tracing-1 to develop February 12, 2020 20:48
@freesig
Copy link
Copy Markdown
Contributor Author

freesig commented Feb 22, 2020

I've found a better option. Tokio tracing already has a Jaeger backend through open telemetry and its way easier to write

@freesig freesig mentioned this pull request Feb 25, 2020
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants