Run unit tests with param warnings as exceptions by default (#1528)

Author: maximlt

hvplot/tests/conftest.py

@@ -1,4 +1,10 @@
 import dask
+import param
+import pytest
+
+from packaging.version import Version
+
+param.parameterized.warnings_as_exceptions = True
 
 from packaging.version import Version
 
@@ -43,3 +49,13 @@ def pytest_collection_modifyitems(config, items):
     # From Dask 2024.3.0 they now use `dask_expr` by default
     # https://github.com/dask/dask/issues/10995
     dask.config.set({'dataframe.query-planning': False})
+
+
+@pytest.fixture
+def disable_param_warnings_as_exceptions():
+    original = param.parameterized.warnings_as_exceptions
+    param.parameterized.warnings_as_exceptions = False
+    try:
+        yield
+    finally:
+        param.parameterized.warnings_as_exceptions = original

hvplot/tests/testhelp.py

@@ -60,6 +60,7 @@ def test_help_style_extension_output(reset_default_backend):
     )
 
 
+@pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
 def test_help_style_compatibility(reset_default_backend):
     # The current backend is plotly but the style options are those of matplotlib
     hvplot.extension('plotly', 'matplotlib', compatibility='matplotlib')

hvplot/tests/testoverrides.py

@@ -2,6 +2,7 @@
 
 import numpy as np
 import pandas as pd
+import pytest
 import xarray as xr
 
 from hvplot.plotting import hvPlot, hvPlotTabular
@@ -44,6 +45,7 @@ def test_define_customize_method(self):
         self.assertNotEqual(opts.options.get('width'), 42)
         self.assertNotEqual(opts.options.get('height'), 42)
 
+    @pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
     def test_attempt_to_override_kind_on_method(self):
         hvplot = hvPlotTabular(self.df, {'scatter': {'kind': 'line'}})
         self.assertIsInstance(hvplot.scatter(y='y'), Scatter)

hvplot/tests/testui.py

@@ -123,6 +123,7 @@ def test_explorer_kwargs_controls():
     assert explorer.axes.width == 200
 
 
+@pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
 def test_explorer_kwargs_controls_error_not_supported():
     with pytest.raises(
         TypeError,
@@ -391,6 +392,7 @@ def test_explorer_xarray_multi_var_extra_dims_no_coord():
     assert ds.hvplot.explorer()
 
 
+@pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
 @pytest.mark.parametrize('kind_tuple', [('scatter', 'points'), ('line', 'paths')])
 @pytest.mark.geo
 def test_explorer_geo_revise_kind(kind_tuple):
@@ -399,6 +401,7 @@ def test_explorer_geo_revise_kind(kind_tuple):
     assert explorer.kind == kind_tuple[1]
 
 
+@pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
 def test_max_rows_curve():
     N = 100001
     x = np.linspace(0.0, 6.4, num=N)
@@ -408,6 +411,7 @@ def test_max_rows_curve():
     assert ui._data.equals(df.head(MAX_ROWS))
 
 
+@pytest.mark.usefixtures('disable_param_warnings_as_exceptions')
 def test_max_rows_sample():
     N = 100001
     x = np.linspace(0.0, 6.4, num=N)

hvplot/ui.py

@@ -553,9 +553,11 @@ def __init__(self, df, **params):
         if 'y' in params:
             params['y_multi'] = params.pop('y') if isinstance(params['y'], list) else [params['y']]
         statusbar_params = {k: params.pop(k) for k in params.copy() if k in StatusBar.param}
+        opts_kwargs = params.pop('opts', {})
         converter = _hvConverter(
             df, x, y, **{k: v for k, v in params.items() if k not in ('x', 'y', 'y_multi')}
         )
+        params['opts'] = opts_kwargs
         # Collect kwargs passed to the constructor but meant for the controls
         extras = {k: params.pop(k) for k in params.copy() if k not in self.param}
         super().__init__(**params)