Wait for node command completion when node is dead (#1250)

* Wait for node command completion when node is dead

* Add test to ensure we no longer wait when node goes dead

* fix lint

Author: AlCalzone

test/model/test_node.py

@@ -407,6 +407,25 @@ async def async_send_command(
     assert task_2.done()
     assert task_2.result() is None
 
+    # mark node as alive
+    event = Event(type="alive")
+    node.handle_alive(event)
+    task = asyncio.create_task(node.async_send_command("mock_cmd"))
+    task_2 = asyncio.create_task(node.endpoints[0].async_send_command("mock_cmd"))
+    await asyncio.sleep(0.01)
+    # we are waiting for the response
+    assert not task.done()
+    assert not task_2.done()
+    # node is marked dead
+    event = Event(type="dead")
+    node.handle_dead(event)
+    await asyncio.sleep(0.01)
+    # we are no longer waiting for the response
+    assert task.done()
+    assert task.result() is None
+    assert task_2.done()
+    assert task_2.result() is None
+
 
 async def test_poll_value(multisensor_6, uuid4, mock_command):
     """Test poll value."""

zwave_js_server/model/node/__init__.py

@@ -503,10 +503,7 @@ async def async_send_command(
         if wait_for_result:
             result = await self.client.async_send_command(message, **kwargs)
             return result
-        if wait_for_result is None and self.status not in (
-            NodeStatus.ASLEEP,
-            NodeStatus.DEAD,
-        ):
+        if wait_for_result is None and self.status not in (NodeStatus.ASLEEP,):
             result_task = asyncio.create_task(
                 self.client.async_send_command(message, **kwargs)
             )