Add method to update the controller's inclusion state #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
MartinHjelmare
changed the title
MartinHjelmare
requested changes
Feb 18, 2025
| self.data["rebuildRoutesProgress"] | ||
| ) | ||
|
|
||
| def update_inclusion_state(self, state: InclusionState) -> None: |
Contributor
There was a problem hiding this comment.
Update the event handler handle_inclusion_state_changed instead.
Each incoming event should have a corresponding event handler in the appropriate model. The event handler should update state as needed before emitting the event, calling event listeners of the event. This is how the library is designed.
Contributor
Author
|
Closing in favor of #1173. That makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to be able to handle the
inclusion state changedevent, which is currently being ignored by HA, leading to a discrepancy between the assumed and actual inclusion state.I'm not sure if this is the right approach. Ideally I'd like a method to update any property, not just the inclusion state, so we don't have to add another when we need to selectively update a different property in the future.