Skip to content

Add driver firmware v15 commands #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2025
Merged

Add driver firmware v15 commands #1260

merged 6 commits into from
Jul 28, 2025

Conversation

@MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Jul 24, 2025 •
edited
Loading

@MartinHjelmare MartinHjelmare marked this pull request as draft July 24, 2025 12:04
@MartinHjelmare MartinHjelmare force-pushed the add-driver-firmware-v15-commands branch from 49525b8 to 2183109 Compare July 24, 2025 12:06
@MartinHjelmare MartinHjelmare added the breaking-change Breaking changes label Jul 24, 2025
AlCalzone
AlCalzone reviewed Jul 24, 2025
View reviewed changes
MartinHjelmare
MartinHjelmare commented Jul 24, 2025
View reviewed changes
test/model/common.py Outdated
@@ -0,0 +1,17 @@
"""Provide common tools for testing Z-Wave JS server models."""

FIRMWARE_UPDATE_INFO = {
Copy link
Contributor Author

@MartinHjelmare MartinHjelmare Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pure move, no changes.

MartinHjelmare
MartinHjelmare commented Jul 24, 2025
View reviewed changes
MartinHjelmare
MartinHjelmare commented Jul 24, 2025
View reviewed changes
MartinHjelmare
MartinHjelmare commented Jul 24, 2025
View reviewed changes
@MartinHjelmare
Copy link
Contributor Author

I'll finish this tomorrow. Please let me know what you think on the open questions above.

@MartinHjelmare MartinHjelmare marked this pull request as ready for review July 25, 2025 16:56
@MartinHjelmare
Copy link
Contributor Author

I think we can merge this now.

@MartinHjelmare MartinHjelmare marked this pull request as draft July 26, 2025 10:13
@MartinHjelmare
Copy link
Contributor Author

I'll make some refactors of the firmware models as a prerequisite to this PR to make it easier to use this in Home Assistant. There are many parts of the node and driver firmware models that are common and we should consolidate those first.

@MartinHjelmare MartinHjelmare force-pushed the add-driver-firmware-v15-commands branch from e2a935e to 7c70a54 Compare July 27, 2025 17:17
@MartinHjelmare
Copy link
Contributor Author

Waiting on #1262 now.

@MartinHjelmare MartinHjelmare force-pushed the add-driver-firmware-v15-commands branch from 7c70a54 to 4f85666 Compare July 28, 2025 10:33
@MartinHjelmare MartinHjelmare marked this pull request as ready for review July 28, 2025 10:33
@MartinHjelmare
Copy link
Contributor Author

I've rebased this PR now. The scope is a lot smaller now after the firmware model refactor that is now merged.

AlCalzone
AlCalzone suggested changes Jul 28, 2025
View reviewed changes
@MartinHjelmare MartinHjelmare merged commit 3b11119 into main Jul 28, 2025
5 checks passed
@MartinHjelmare MartinHjelmare deleted the add-driver-firmware-v15-commands branch July 28, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlCalzone AlCalzone AlCalzone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change Breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinHjelmare @AlCalzone