Refactor firmware models #1262
Refactor firmware models #1262
Conversation
There was a problem hiding this comment.
If I understand correctly, the number of files is not exposed for the driver firmware upgrade progress. Even though this is correct now, I wonder if we should expose that information too to stay future-proof without having to touch this again. Just in case zwave-js gains support for multi-step firmware updates for adapters.
Other than that LGTM.
| current_file: int = field(init=False) | ||
| total_files: int = field(init=False) |
There was a problem hiding this comment.
Do you mean the attributes current_file and total_files?
If it's not supported now, I don't think we should add it. There's no problem with adding them later when they are supported by driver updates.
There was a problem hiding this comment.
Yes. If we add it now, it's not technically wrong - we're updating file 1 of 1 always. But we don't need to touch the entire stack again when/if that functionality is added in zwave-js.
I don't mind either way, just trying to avoid unnecessary work in the future.
There was a problem hiding this comment.
Ok. This is a refactor PR though so we shouldn't add new attributes here. We can do it later when we have time.
Uh oh!
There was an error while loading. Please reload this page.