Skip to content

Conversation

@AlexC
Copy link

@AlexC AlexC commented Nov 29, 2025

Proposed change

This allows those who have added their Pets as "People" within Home Assistant to attach the device to them, opening up the use of cards that show presence information for a person rather than just a binary sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This allows those who have added their Pets as "People" within Home
Assistant to attach the device to them, opening up the use of cards that
show presence information for a person rather than just a binary sensor.
Copilot AI review requested due to automatic review settings November 29, 2025 15:43
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexC

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @benleb, @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (surepetcare) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of surepetcare can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign surepetcare Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds device tracker support for Sure Petcare pets, enabling users to track pet locations (inside/outside) and attach these trackers to "People" entities in Home Assistant for enhanced presence monitoring through person cards.

Key Changes

  • Adds device_tracker platform to map pet locations to HOME/NOT_HOME states
  • Implements state tracking based on Sure Petcare API location data (inside/outside/unknown)
  • Exposes location details through extra state attributes (since, where)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
homeassistant/components/surepetcare/device_tracker.py New platform implementation that creates TrackerEntity instances for pets, mapping location data to device tracker states
homeassistant/components/surepetcare/init.py Adds DEVICE_TRACKER to the list of supported platforms
tests/components/surepetcare/test_device_tracker.py Comprehensive tests validating entity creation, state mapping, and attribute exposure for different location scenarios
tests/components/surepetcare/conftest.py Updates mock config to include additional test pets (24681, 24682)
tests/components/surepetcare/init.py Adds mock data for outdoor and unknown location pets to support comprehensive testing

AlexC and others added 2 commits November 29, 2025 16:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@AlexC
Copy link
Author

AlexC commented Nov 29, 2025

@Danielhiversen / @benleb I'm aware of the duplication here in regards to the existing Binary Sensor and this new Device Tracker. It feels like the Binary Sensor would become redundant with this change, and likely could be marked as deprecated to be removed in a later version (to give people time to move to the Device Tracker) - would that be an acceptable approach here? I am unfamiliar with how HA would typically handle this, or even if it's an issue having both in place.

FYI @lp55 as I believe you're taking some of the workload from Ben here now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants