feat: Add interactive listen and --filter-x param for session filtering #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarp
approved these changes
Oct 14, 2025
alvarp
approved these changes
Oct 14, 2025
|
@claude review |
alexbouchardd
changed the title
alexbouchardd
changed the title
alexbouchardd
changed the base branch from
feat/listen-keyboard-shortcut
to
main
alexluong
approved these changes
Oct 20, 2025
| TargetURL *url.URL | ||
| Sources []*hookdecksdk.Source | ||
| Connections []*hookdecksdk.Connection | ||
| Filters interface{} // Session filters (stored as interface{} to avoid circular dependency) |
There was a problem hiding this comment.
what's the circular dependency?
mkherlakian
reviewed
Oct 21, 2025
Comment on lines
+298
to
+304
| if activeCount > warningThreshold && !p.maxConnWarned { | ||
| p.maxConnWarned = true | ||
| p.renderer.OnConnectionWarning(activeCount, p.transport.MaxConnsPerHost) | ||
| } else if activeCount < resetThreshold && p.maxConnWarned { | ||
| // Reset warning flag when load decreases | ||
| p.maxConnWarned = false | ||
| } |
There was a problem hiding this comment.
@alexbouchardd My version warned whne approaching max connections https://github.com/hookdeck/hookdeck-cli/pull/153/files?new_files_changed=true&diff=unified#diff-b41d02f71c670ff801d99892d32ef6dd36e43fcdf4c12c044cd34a073cc18200R285-R296 Probably something to keep? This code flips maxConnWarned to true but doesn't seem do anything about it.
There was a problem hiding this comment.
p.renderer.OnConnectionWarning(activeCount, p.transport.MaxConnsPerHost) handles the rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.