Skip to content

New test macros and code cleanup #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

New test macros and code cleanup #261

wants to merge 41 commits into from

Conversation

TheAssembler1
Copy link
Collaborator

@TheAssembler1 TheAssembler1 commented May 19, 2025 •
edited
Loading

Checklist:

  • New and existing unit tests pass locally with my changes

Done Checklist:

  • Capitalize first letter of first word in logs
  • Remove newline from PGOTO_ERROR calls
  • Replace PGOTO_ERROR(-1, str) with PGOTO_ERROR(FAIL, str)
  • Remove unneccesary calls to fflush
  • Replace goto with PDC macros PGOTO_DONE and PGOTO_ERROR
  • Removed unnecessary comments with unused code
  • Remove TANG_DEBUG macro and usage
  • Removed pritnln and stderr_println and usages. replaced with LOG_ERROR, LOG_INFO
  • Use new TASSERT macros in CI tests

@TheAssembler1 TheAssembler1 self-assigned this May 19, 2025
@TheAssembler1 TheAssembler1 changed the title Tests logging New test macros and code cleanup May 19, 2025
@jeanbez jeanbez changed the title New test macros and code cleanup Draft: New test macros and code cleanup May 20, 2025
@TheAssembler1 TheAssembler1 requested review from houjun and jeanbez May 31, 2025 21:20
@TheAssembler1 TheAssembler1 marked this pull request as ready for review May 31, 2025 21:20
@TheAssembler1 TheAssembler1 requested a review from a team as a code owner May 31, 2025 21:20
@TheAssembler1 TheAssembler1 added the type: enhancement New feature or request label May 31, 2025
@TheAssembler1 TheAssembler1 changed the title Draft: New test macros and code cleanup New test macros and code cleanup Jun 2, 2025
@TheAssembler1 TheAssembler1 mentioned this pull request Jun 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houjun houjun houjun approved these changes

@jeanbez jeanbez jeanbez approved these changes

Assignees

@TheAssembler1 TheAssembler1

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheAssembler1 @houjun @jeanbez